Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TT-69] read the seconds to check for key space changes from config file, als… #3059

Merged
merged 5 commits into from
May 6, 2020
Merged

[TT-69] read the seconds to check for key space changes from config file, als… #3059

merged 5 commits into from
May 6, 2020

Conversation

sredxny
Copy link
Contributor

@sredxny sredxny commented Apr 29, 2020 •
edited
Loading

Description

Allow users to set the number of seconds before GW check again for key space changes (key_space_sync_interval)

Related Issue

#3058

Motivation and Context

give solution to #3058 and accomplish one of the requisites to build the MDCB testing framework

How This Has Been Tested

  • Starts a MDCB setup
  • Set 1 seconds as value of this field
  • Restart slaved GW
  • Check logs, we must see every second a record saying that its checking for key space changes

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If pulling from your own
    fork, don't request your master!
  • Make sure you are making a pull request against the master branch (left side). Also, you should start
    your branch off our latest master.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • Modules and vendor dependencies have been updated; run go mod tidy && go mod vendor
  • When updating library version must provide reason/explanation for this update.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • go fmt -s
    • go vet

buger
buger reviewed Apr 30, 2020
View reviewed changes
config/config.go Outdated Show resolved Hide resolved
@sredxny sredxny requested a review from buger April 30, 2020 13:22
buger
buger reviewed Apr 30, 2020
View reviewed changes
cli/linter/schema.json Outdated Show resolved Hide resolved
@sredxny sredxny requested a review from buger April 30, 2020 16:17
@buger buger merged commit 08e9132 into master May 6, 2020
@sredxny sredxny mentioned this pull request Aug 20, 2020
Merged
@sredxny
Copy link
Contributor Author

sredxny commented Aug 20, 2020

Documentation TykTechnologies/tyk-docs#1386

@gregdelhon gregdelhon changed the title read the seconds to check for key space changes from config file, als… [TT-69] read the seconds to check for key space changes from config file, als… Aug 20, 2020
@matiasinsaurralde
Copy link
Contributor

/release to release-1.0

@tykbot
Copy link

tykbot bot commented Sep 10, 2020

@matiasinsaurralde Release branch not found

@matiasinsaurralde
Copy link
Contributor

/release to release-3.1

@tykbot
Copy link

tykbot bot commented Sep 10, 2020

Working on it! Note that it can take a few minutes.

@tykbot
Copy link

tykbot bot commented Sep 10, 2020

@matiasinsaurralde Succesfully merged 08e913217037b1dad1b60d2a5a07446e52ce8913 to release-3.1 branch.

tykbot bot pushed a commit that referenced this pull request Sep 10, 2020
@sredxny
read the seconds to check for key space changes from config file, als… (
7a13ac5 
#3059)

<!-- Provide a general summary of your changes in the Title above -->

## Description
Allow users to set the number of seconds before GW check again for key space changes

## Related Issue
#3058

## Motivation and Context
give solution to #3058 and accomplish one of the requisites to build the MDCB testing framework

## How This Has Been Tested
- Starts a MDCB setup
- Set 1 seconds  as value of this field
- Restart slaved GW
- Check logs, we must see every second a record saying that its checking for key space changes

## Screenshots (if appropriate)

## Types of changes
<!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Checklist
<!-- Go over all the following points, and put an `x` in all the boxes that apply -->
<!-- If you're unsure about any of these, don't hesitate to ask; we're here to help! -->
- [x] Make sure you are requesting to **pull a topic/feature/bugfix branch** (right side). If pulling from your own
      fork, don't request your `master`!
- [x] Make sure you are making a pull request against the **`master` branch** (left side). Also, you should start
      *your branch* off *our latest `master`*.
- [ ] My change requires a change to the documentation.
  - [ ] If you've changed APIs, describe what needs to be updated in the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] Modules and vendor dependencies have been updated; run `go mod tidy && go mod vendor`
- [ ] When updating library version must provide reason/explanation for this update.
- [ ] I have added tests to cover my changes.
- [ ] All new and existing tests passed.
- [x] Check your code additions will not fail linting checks:
  - [x] `go fmt -s`
  - [x] `go vet`

(cherry picked from commit 08e9132)
@matiasinsaurralde
Copy link
Contributor

/release to release-3-lts

@tykbot
Copy link

tykbot bot commented Sep 10, 2020

Working on it! Note that it can take a few minutes.

tykbot bot pushed a commit that referenced this pull request Sep 10, 2020
@sredxny
read the seconds to check for key space changes from config file, als… (
c2a015f 
#3059)

<!-- Provide a general summary of your changes in the Title above -->

## Description
Allow users to set the number of seconds before GW check again for key space changes

## Related Issue
#3058

## Motivation and Context
give solution to #3058 and accomplish one of the requisites to build the MDCB testing framework

## How This Has Been Tested
- Starts a MDCB setup
- Set 1 seconds  as value of this field
- Restart slaved GW
- Check logs, we must see every second a record saying that its checking for key space changes

## Screenshots (if appropriate)

## Types of changes
<!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Checklist
<!-- Go over all the following points, and put an `x` in all the boxes that apply -->
<!-- If you're unsure about any of these, don't hesitate to ask; we're here to help! -->
- [x] Make sure you are requesting to **pull a topic/feature/bugfix branch** (right side). If pulling from your own
      fork, don't request your `master`!
- [x] Make sure you are making a pull request against the **`master` branch** (left side). Also, you should start
      *your branch* off *our latest `master`*.
- [ ] My change requires a change to the documentation.
  - [ ] If you've changed APIs, describe what needs to be updated in the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] Modules and vendor dependencies have been updated; run `go mod tidy && go mod vendor`
- [ ] When updating library version must provide reason/explanation for this update.
- [ ] I have added tests to cover my changes.
- [ ] All new and existing tests passed.
- [x] Check your code additions will not fail linting checks:
  - [x] `go fmt -s`
  - [x] `go vet`

(cherry picked from commit 08e9132)
@tykbot
Copy link

tykbot bot commented Sep 10, 2020

@matiasinsaurralde Succesfully merged 08e913217037b1dad1b60d2a5a07446e52ce8913 to release-3-lts branch.

@tbuchaillot
Copy link
Contributor

/release to release-3

@tykbot
Copy link

tykbot bot commented Apr 13, 2021

Working on it! Note that it can take a few minutes.

tykbot bot pushed a commit that referenced this pull request Apr 13, 2021
@sredxny
read the seconds to check for key space changes from config file, als… (
bfd1444 
#3059)

<!-- Provide a general summary of your changes in the Title above -->

## Description
Allow users to set the number of seconds before GW check again for key space changes

## Related Issue
#3058

## Motivation and Context
give solution to #3058 and accomplish one of the requisites to build the MDCB testing framework

## How This Has Been Tested
- Starts a MDCB setup
- Set 1 seconds  as value of this field
- Restart slaved GW
- Check logs, we must see every second a record saying that its checking for key space changes

## Screenshots (if appropriate)

## Types of changes
<!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Checklist
<!-- Go over all the following points, and put an `x` in all the boxes that apply -->
<!-- If you're unsure about any of these, don't hesitate to ask; we're here to help! -->
- [x] Make sure you are requesting to **pull a topic/feature/bugfix branch** (right side). If pulling from your own
      fork, don't request your `master`!
- [x] Make sure you are making a pull request against the **`master` branch** (left side). Also, you should start
      *your branch* off *our latest `master`*.
- [ ] My change requires a change to the documentation.
  - [ ] If you've changed APIs, describe what needs to be updated in the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] Modules and vendor dependencies have been updated; run `go mod tidy && go mod vendor`
- [ ] When updating library version must provide reason/explanation for this update.
- [ ] I have added tests to cover my changes.
- [ ] All new and existing tests passed.
- [x] Check your code additions will not fail linting checks:
  - [x] `go fmt -s`
  - [x] `go vet`

(cherry picked from commit 08e9132)
@tykbot
Copy link

tykbot bot commented Apr 13, 2021

@tbuchaillot Succesfully merged 08e913217037b1dad1b60d2a5a07446e52ce8913 to release-3 branch.

@sredxny
Copy link
Contributor Author

sredxny commented Jan 14, 2022

/release to release-3.2

@tykbot
Copy link

tykbot bot commented Jan 14, 2022

Working on it! Note that it can take a few minutes.

@tykbot
Copy link

tykbot bot commented Jan 14, 2022

@sredxny Seems like there is conflict and it require manual merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furkansenharputlu furkansenharputlu Awaiting requested review from furkansenharputlu

@tbuchaillot tbuchaillot Awaiting requested review from tbuchaillot

@buger buger Awaiting requested review from buger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sredxny @matiasinsaurralde @tbuchaillot @buger