Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on Apply policies, check the highest value for each field, without considering relation with another field #2981

Merged
merged 5 commits into from
Mar 31, 2020

Conversation

sredxny
Copy link
Contributor

@sredxny sredxny commented Mar 31, 2020

always select the biggest value, it doesn't matter if it have any relation with another value, Eg: rate with per, throttle_interval with throttle_retry_limit, quota_max with quota_renewal_rate, and so on. now they are chosen independently

related to: https://github.com/TykTechnologies/tyk-analytics/issues/1814

@sredxny sredxny changed the title Fix 1814 Fix 1814 {do not merge} Mar 31, 2020
@sredxny sredxny changed the title Fix 1814 {do not merge} on Apply policies, check the highest value for each field, without considering relation with another field {do not merge} Mar 31, 2020
@sredxny sredxny changed the title on Apply policies, check the highest value for each field, without considering relation with another field {do not merge} on Apply policies, check the highest value for each field, without considering relation with another field Mar 31, 2020
@sredxny sredxny requested a review from buger March 31, 2020 18:59
@buger buger merged commit e64b806 into master Mar 31, 2020
@buger
Copy link
Member

buger commented Mar 31, 2020

/release to release-2.10

@buger buger deleted the fix-1814 branch March 31, 2020 19:02
@tykbot
Copy link

tykbot bot commented Mar 31, 2020

Working on it! Note that it can take a few minutes.

tykbot bot pushed a commit that referenced this pull request Mar 31, 2020
…nsidering relation with another field (#2981)

always select the biggest value, it doesn't matter if it have any relation with another value, Eg: rate with per,  throttle_interval with throttle_retry_limit, quota_max with quota_renewal_rate, and so on. now they are chosen independently

related to: TykTechnologies/tyk-analytics#1814

(cherry picked from commit e64b806)
@tykbot
Copy link

tykbot bot commented Mar 31, 2020

@buger Succesfully merged e64b80661db553a1b574c2c4872373197459d9b7 to release-2.10 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants