You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it would be a good idea to re-export elementwise_loglikelihoods and generated_quantities from DynamicPPL. v0.9.2 since these methods are mainly meant to be used by the end-user, rather than just internally.
It also bumps the compat-entry of DynamicPPL from 0.9.2, on which these are available (though this is the only difference between 0.9.1 and 0.9.2).
Is there going to be some documentation on turing.ml regarding both methods?
IMO that should be included into a larger effort put into a tutorial about diagnostics + we should really have DynamicPPL and MCMCChains also rendered under the API section IMO.
Is there going to be some documentation on turing.ml regarding both methods?
For now there are at least docstrings, but I guess it would help if we could prepare and update the documentation in DynamicPPL (or e.g. MCMCChains) more independently.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
torfjelde
requested review from
cpfiffer and
devmotion
and removed request for
cpfiffer
I think it would be a good idea to re-export
elementwise_loglikelihoodsandgenerated_quantitiesfrom DynamicPPL. v0.9.2 since these methods are mainly meant to be used by the end-user, rather than just internally.It also bumps the compat-entry of DynamicPPL from 0.9.2, on which these are available (though this is the only difference between 0.9.1 and 0.9.2).