Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for "Optim" to "1.0" for package test #1399

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 6, 2020

This pull request changes the compat entry for the Optim package from 0.22 to 0.22, 1.0 for package test.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

@devmotion devmotion force-pushed the compathelper/new_version/2020-09-06-00-13-11-136-428091572 branch from 9fcfff5 to 0313c79 Compare September 6, 2020 00:13
@codecov
Copy link

codecov bot commented Sep 6, 2020

Codecov Report

Merging #1399 into master will increase coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1399      +/-   ##
==========================================
+ Coverage   66.95%   67.20%   +0.25%     
==========================================
  Files          25       26       +1     
  Lines        1619     1668      +49     
==========================================
+ Hits         1084     1121      +37     
- Misses        535      547      +12     
Impacted Files Coverage Δ
src/core/deprecations.jl 0.00% <0.00%> (ø)
src/core/ad.jl 77.47% <0.00%> (+3.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1ab7e0...0313c79. Read the comment docs.

@devmotion
Copy link
Member

Tests did not use Optim 1.0.

@devmotion devmotion closed this Sep 14, 2020
@devmotion devmotion reopened this Sep 14, 2020
@devmotion devmotion merged commit ae24c28 into master Sep 14, 2020
@devmotion devmotion deleted the compathelper/new_version/2020-09-06-00-13-11-136-428091572 branch September 14, 2020 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant