-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GitHub CodeQL and remove LGTM #1918
Conversation
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Codecov Report
@@ Coverage Diff @@
## main #1918 +/- ##
==========================================
+ Coverage 80.48% 85.58% +5.10%
==========================================
Files 248 248
Lines 23373 23384 +11
Branches 4233 4233
==========================================
+ Hits 18811 20013 +1202
+ Misses 3528 2287 -1241
- Partials 1034 1084 +50
|
@@ -211,7 +211,7 @@ | |||
"""For `label_type="object_detection"` only a list of multiples of 90 degrees is supported.""" | |||
) | |||
if isinstance(self.angles, list): | |||
for angle in self.angles: # lgtm [py/non-iterable-in-for-loop] | |||
for angle in self.angles: |
Check failure
Code scanning / CodeQL
Non-iterable used in for loop
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
@@ -194,7 +194,7 @@ | |||
else: | |||
# NHWC <-- NCHW | |||
x = x_nchw.permute(0, 2, 3, 1) | |||
elif x_ndim == 5: # lgtm [py/redundant-comparison] | |||
elif x_ndim == 5: |
Check warning
Code scanning / CodeQL
Redundant comparison
@@ -104,7 +104,7 @@ | |||
|
|||
if x_ndim == 4: | |||
x = x_nhwc | |||
elif x_ndim == 5: # lgtm [py/redundant-comparison] | |||
elif x_ndim == 5: |
Check warning
Code scanning / CodeQL
Redundant comparison
@@ -258,7 +252,7 @@ | |||
if dk * alpha < temp2: | |||
temp1 = temp2 / dk | |||
else: | |||
temp2 = u[i] - x_cp[i] # lgtm [py/multiple-definition] | |||
temp2 = u[i] - x_cp[i] |
Check warning
Code scanning / CodeQL
Variable defined multiple times
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
This pull request fixes 1 alert when merging 3985b09 into e7c763b - view on LGTM.com fixed alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
Description
This pull request updates GitHub CodeQL to replace LGTM and removes LGTM because of its deactivation in December 2022.