Do you have a specific error message that might be helpful to figure out what's going on that causes it not to work? The deps ecc-jsbn, tweetnacl etc that are in optionalDependencies are there because sshpk very carefully only calls require() on them if you use the actual functions that depend on those modules (i.e. you can require('sshpk') and it does not require any of those modules automatically -- you have to do something like make an ED25519 key and call .sign() on it before we require('tweetnacl')).

If webpack is not able to deal with the require() calls being optional and inside functions, I suggest that would be a bug in webpack, not in this module. But if there's somewhere where we are accidentally causing these modules to be require()'d when they aren't actually been used, I would like to know about that so I can fix it.

Sorry this has been sitting open for so long -- browser issues are not really a high priority for me (or the other people at Joyent who have worked on this module), and I can't really offer support for how to use sshpk with webpack in general (since I don't use it), but I'm happy to take reports of something more specific, like a require() happening when it shouldn't and get them fixed up.

stop using optional deps to fix webpack #53

Description

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions