Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 fix and refactoring #263

Merged
merged 4 commits into from
Jun 8, 2023
Merged

S3 fix and refactoring #263

merged 4 commits into from
Jun 8, 2023

Conversation

luciferlinx101
Copy link
Collaborator

  • Write file and image S3 fix
  • Refactored s3,resource helper

aws_secret_access_key=get_config("AWS_SECRET_ACCESS_KEY"),
)

def upload_to_s3(file,path):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add S3Helper class

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

type=file_type,
channel="OUTPUT",
agent_id=agent_id)
print(resource)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

import datetime


def make_written_file_resource(file_name: str, agent_id: int, file, channel):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add it in ResourceHelper

Copy link

@bateller bateller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add S3Helper class

@luciferlinx101 luciferlinx101 merged commit c202d0c into dev Jun 8, 2023
Tarraann pushed a commit that referenced this pull request Jun 19, 2023
* Updated

* Refactored and fixed S3 upload for write,image

* Refactored and fixed S3 upload for write,image

* Refactored
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants