-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S3 fix and refactoring #263
Conversation
luciferlinx101
commented
Jun 8, 2023
- Write file and image S3 fix
- Refactored s3,resource helper
superagi/helper/s3_helper.py
Outdated
aws_secret_access_key=get_config("AWS_SECRET_ACCESS_KEY"), | ||
) | ||
|
||
def upload_to_s3(file,path): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add S3Helper class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
superagi/helper/resource_helper.py
Outdated
type=file_type, | ||
channel="OUTPUT", | ||
agent_id=agent_id) | ||
print(resource) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
superagi/helper/resource_helper.py
Outdated
import datetime | ||
|
||
|
||
def make_written_file_resource(file_name: str, agent_id: int, file, channel): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add it in ResourceHelper
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add S3Helper class
* Updated * Refactored and fixed S3 upload for write,image * Refactored and fixed S3 upload for write,image * Refactored