Update index.html with mobile first, responsive design #189
Conversation
|
This pull request will be automatically merged by worlddriven in 19 day(s) and 16 hour(s). To speed up or delay the merge review the pull request:
|
There was a problem hiding this comment.
I like it.
(I think for Pixel 2 411x731 (my phone) the merge_at image is too big.)
I'm not so much into UI/UX, so feel free to play around. Just some of my thoughts:
- Keep the tech stack and dependencies simple (not necessary including something like bootstrap)
- Maybe splitting the three phases into something like tabs, with the first dominant and the others more 'greyed' out, to show the current status and don't distract with the long term idea.
|
|
||
| </div> | ||
| <center><h6>Trustable service landscape</h6></center> | ||
| <h4>Trustable service landscape</h4> |
There was a problem hiding this comment.
I had this one very small because I'm not so sure about that tagline.
Somehow it describes the long (long long) term idea pretty good. Right now I'm more into getting feedback about the basic auto-merge idea.
So presenting mainly the auto merger and if this is of interest continue with Phase 2 and 3.
Does that make sense?
In that context, the tagline does not fit so well.
What do you think?
So the change is fine, just wanted to give some background.
There was a problem hiding this comment.
Yeah I don't love the tagline either. If we come up something better before this merges, which will be a while due to the pending merges prior to this that I'll need to incorporate thus resetting the timer, I'll update it; if not, I'll probably just remove it for now.
I agree with focusing on the auto-merge for now. I'd rather do one thing great that loads of things okay.
There was a problem hiding this comment.
I'm going to leave some slogan ideas below - I'll just add them here as I think of them rather than a new comment every time:
Collaboration Through Automation
Driving Development
There was a problem hiding this comment.
Hm, not yet convinced:
- Automation supported collaboration (in yours I see the automation part too strong. Not sure if it works in English, in German, this could be a pun)
- Driving Development would be a bit too much
Drivein my opinion :-)
I thought about: When we go somehow in the 'tab' idea (for each phase a something like a tab), we could also adapt the tagline for each phase.
So Phase 1 more centered around the automated merging / collaboration
Phase 2 more a service idea tag line ...
| @@ -2,7 +2,7 @@ | |||
| <html lang="en"> | |||
| <head> | |||
| <meta charset="utf-8"> | |||
| <title>World driven - pull request auto merge</title> | |||
| <title>World Driven - Pull Request Auto-Merge</title> | |||
There was a problem hiding this comment.
Let's start the naming discussion here, especially because I couldn't make up my mind yet :-)
- World Driven
- worlddriven
- world-driven
Any opinion, if yes, why?
There was a problem hiding this comment.
I don't like worlddriven - compounds with double letters don't work for me - but could be swayed towards World-Driven I think. I'm envisaging a logo where the dash is the pull request logo and think it works quite well. It also fits in nicely with my preferred auto-merge.
There was a problem hiding this comment.
K, let's do World Driven for now, also thinking that the current domain worlddriven.org fits better (otherwise it should be world-driven.org :-))
There was a problem hiding this comment.
I think people would forgive the lack of a hyphen in the URL. I for one wouldn't expect a project called World-Driven to be at world-driven.org. Regardless, World Driven works for me and may in fact be my first choice.
|
Thank you for the review. Check the |
I'll have a look, should be relatively easy to tweak these things now the media queries are pared down.
Absolutely with you on that one.
I'll have to think about this one there are a lot of possible options for that sort of thing. A separate page for the long term ideas is the obvious way, could make them expandable and style them similarly to folded code to fit with the theme. |
The merge_at image forced horizontal scrolling on small screens and looked awful as a result. This commit adds two other versions of the image appropriately cropped to work responsively to screen size.
|
This pull request was merged by worlddriven. |
These commits make the index page look better. Changes include:
No white background on the logo and responsive sizing
Media queries are massively simplified as part of mobile first design. The site should now look decent on pretty much any device and is easier to change
Merge_to image has alternate crops of it which load depending upon screen size. Old image looked awful on small screens and introduced horizontal scrolling to them which is never good
Slightly changed which colours from the colour scheme were used in order to make links look nice - i.e. a bottom border and a colour that matches the logo
Bigger font, that is again responsive to the screen size, and more space around things in general
Paler background image as I found it a little bit too dark and distracting when reading at its current opacity