Ignore new error that we didn't enforced before. #6717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dropping support for python 3.4 may be necessary.., |
|
As Theano isn’t well maintained, I do not like much that option.
I would prefer to have a if in the import code that does the right thing for different Python version.
From: rpgoldman <notifications@github.com>
Sent: Wednesday, August 21, 2019 10:17 AM
To: Theano/Theano <Theano@noreply.github.com>
Cc: Frederic Bastien <fbastien@nvidia.com>; Author <author@noreply.github.com>
Subject: Re: [Theano/Theano] Ignore new error that we didn't enforced before. (#6717)
Dropping support for python 3.4 may be necessary..,
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#6717?email_source=notifications&email_token=AABMF62KBXNY5LZ3JEVSQILQFVE7DA5CNFSM4IOHPLFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4Z2B6A#issuecomment-523477240>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AABMF6YVGOWILCBO24DOXS3QFVE7DANCNFSM4IOHPLFA>.
…-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information. Any unauthorized review, use, disclosure or distribution
is prohibited. If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
|
…_0 get installed in Python 3.4, but it give an error that is doesnt support it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.