Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics cardinality fixes #6315

Merged
merged 2 commits into from
Jun 8, 2023
Merged

Metrics cardinality fixes #6315

merged 2 commits into from
Jun 8, 2023

Conversation

adriansmares
Copy link
Contributor

Summary

This PR lowers the cardinality of certain metrics, in order to lower the space usage.

Changes

  • Do not accumulate forwarded uplinks and received downlinks by application ID.
  • Do not accumulate UDP unmarshaling errors by value, as the value really contains the value in the case of numbers.

Testing

🐒

Regressions

N/A. I've double checked that our aggregations in the ECS templates don't depend on these labels, and they do not.

Notes for Reviewers

No need to review. Strictly CI.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@adriansmares adriansmares added this to the v3.26.1 milestone Jun 8, 2023
@adriansmares adriansmares self-assigned this Jun 8, 2023
@github-actions github-actions bot added c/application server This is related to the Application Server c/gateway server This is related to the Gateway Server labels Jun 8, 2023
@adriansmares adriansmares marked this pull request as ready for review June 8, 2023 11:48
@adriansmares adriansmares merged commit 93342a7 into v3.26 Jun 8, 2023
@adriansmares adriansmares deleted the fix/gs-metrics-card branch June 8, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/application server This is related to the Application Server c/gateway server This is related to the Gateway Server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant