Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Invitation store interface #6310

Merged
merged 6 commits into from
Jun 7, 2023
Merged

Refactor Invitation store interface #6310

merged 6 commits into from
Jun 7, 2023

Conversation

nicholaspcr
Copy link
Contributor

Summary

References #5587

Changes

  • Move SetInvitationAcceptedBy checks to user_registry.
  • Add tests from store to user_registry

Testing

Unit tests

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@nicholaspcr nicholaspcr added the technical debt Not necessarily broken, but could be done better/cleaner label Jun 5, 2023
@nicholaspcr nicholaspcr self-assigned this Jun 5, 2023
@nicholaspcr nicholaspcr requested a review from adriansmares as a code owner June 5, 2023 18:22
@github-actions github-actions bot added c/identity server This is related to the Identity Server compat/db This could affect Database compatibility labels Jun 5, 2023
@nicholaspcr nicholaspcr force-pushed the refactor/5587-invitation-store branch from 6e3bc0c to b541013 Compare June 6, 2023 12:09
@adriansmares adriansmares added this to the v3.26.1 milestone Jun 6, 2023
adriansmares
adriansmares suggested changes Jun 6, 2023
View reviewed changes
pkg/identityserver/bunstore/invitation_store.go Outdated Show resolved Hide resolved
pkg/identityserver/user_registry.go Show resolved Hide resolved
pkg/identityserver/user_registry_test.go Outdated Show resolved Hide resolved
pkg/identityserver/user_registry_test.go Outdated Show resolved Hide resolved
@nicholaspcr nicholaspcr force-pushed the refactor/5587-invitation-store branch from b541013 to 5e8033e Compare June 7, 2023 13:47
@nicholaspcr nicholaspcr force-pushed the refactor/5587-invitation-store branch from 5e8033e to 6e87e87 Compare June 7, 2023 14:35
@nicholaspcr nicholaspcr requested a review from adriansmares June 7, 2023 14:36
@nicholaspcr nicholaspcr force-pushed the refactor/5587-invitation-store branch from 6e87e87 to 7330890 Compare June 7, 2023 15:35
adriansmares
adriansmares approved these changes Jun 7, 2023
View reviewed changes
pkg/identityserver/user_registry_test.go Outdated Show resolved Hide resolved
@nicholaspcr nicholaspcr force-pushed the refactor/5587-invitation-store branch 2 times, most recently from 7330890 to 3662329 Compare June 7, 2023 18:09
@nicholaspcr nicholaspcr merged commit 3114fe6 into v3.26 Jun 7, 2023
@nicholaspcr nicholaspcr deleted the refactor/5587-invitation-store branch June 7, 2023 18:36
@nicholaspcr nicholaspcr mentioned this pull request Jun 8, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriansmares adriansmares adriansmares approved these changes

Assignees

@nicholaspcr nicholaspcr

Labels
c/identity server This is related to the Identity Server compat/db This could affect Database compatibility technical debt Not necessarily broken, but could be done better/cleaner
Projects
None yet
Milestone
v3.26.1
Development

Successfully merging this pull request may close these issues.
2 participants
@nicholaspcr @adriansmares