Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Fibonacci in Perl #1944

Merged
merged 11 commits into from
Oct 1, 2020
Merged

Added Fibonacci in Perl #1944

merged 11 commits into from
Oct 1, 2020

Conversation

SourabhBadhya
Copy link
Contributor

@SourabhBadhya SourabhBadhya commented Oct 1, 2020 •
edited by jrg94
Loading

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder!
For simplicity, please make sure that your pull request includes one and only one contribution.

Complete the Applicable Sections Below

Find which section best describes your pull request and make sure you fill it out. To start, let us know which issue you've fixed.

Code Snippets

  • I named the pull request using Added/Updated <Sample Program> in <Language> format
  • I created/updated the language README
    • I added the sample program name to the README
    • I added fun facts (i.e. debut, developer, typing, etc.)
    • I added reference link(s) to the README
    • I added solution citations when necessary (see plagiarism)

Testing

  • I named the pull request using Added/Updated <Language>/<Project> Testing format
  • I followed the testinfo template, if applicable

Notes

Feel free to describe what you added or updated.

@jrg94 jrg94 requested a review from a team October 1, 2020 20:47
@jrg94 jrg94 self-assigned this Oct 1, 2020
@jrg94 jrg94 added enhancement Any code that improves the repo fibonacci See: https://sampleprograms.io/projects/fibonacci/ labels Oct 1, 2020
@jrg94 jrg94 added this to the 500 Code Snippets milestone Oct 1, 2020
jrg94
jrg94 approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition!

@jrg94 jrg94 merged commit 5fcd26f into TheRenegadeCoder:master Oct 1, 2020
@SourabhBadhya
Copy link
Contributor Author

I think there was a problem while merging the four pull requests that I had done. Only #1944 pull request was reflected on the master repo. The changes made by pull requests #1920 , #1929 , #1932 were not reflected in the master repo. This is probably due to the fact that #1944 is a branch which has commits wherein I have removed the other files mentioned in the other 3 pull requests. I request you to only merge the last commit rather than all the commits or if any other solution exists let me know.

@jrg94 jrg94 mentioned this pull request Oct 2, 2020
Merged
@jrg94
Copy link
Member

jrg94 commented Oct 2, 2020 •
edited
Loading

I see what you're saying! I tried reverting this change (#1990), but it seems the only code that comes back is the AutoHotKey script.

@jrg94
Copy link
Member

jrg94 commented Oct 2, 2020

I committed the revert. You may need to reopen this one. I'm not sure what to do about the other two pull requests: #1920 and #1929.

@SourabhBadhya
Copy link
Contributor Author

I will add the all the files to this branch itself. Then just merge the files. I think this should work.

@SourabhBadhya
Copy link
Contributor Author

SourabhBadhya commented Oct 2, 2020 •
edited
Loading

I have opened a new pull request (#1991 ) which contains all the files. I think it will look fine after merging. If there any issues let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrg94 jrg94 jrg94 approved these changes

Assignees

@jrg94 jrg94

Labels
enhancement Any code that improves the repo fibonacci See: https://sampleprograms.io/projects/fibonacci/
Projects
Code Snippets
Archived in project
Milestone
500 Code Snippets
Development

Successfully merging this pull request may close these issues.

Add Fibonacci in Perl
2 participants
@SourabhBadhya @jrg94