Added Longest Common Subsequence in Java & C++ #1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the code for Longest common sub-sequence.
This is code for Longest Common Sub-Sequence, in java language.
This is Longest Common Sub-Sequence code in java language.
jrg94
changed the title
jrg94
requested changes
Oct 12, 2019
There was a problem hiding this comment.
Looks good to me, but they currently aren't being tested: https://travis-ci.com/TheRenegadeCoder/sample-programs/jobs/245039381#L562-L581
I think that's because we use "lcs" for the file names. It's a bad abbreviation, but it's what we use. You'll have to update your files accordingly for the testing to trigger.
jrg94
added
hacktoberfest
Formated the indentation, and name of file updated from longest-common-subsequence to lcs.
Updated the name of file from longest-common-subsequence to lcs
Corrected the link for longest-common-subsequence.
|
Done the changes, you requested. |
Corrected some piece of code
Corrected some piece of code.
jrg94
requested changes
Oct 13, 2019
jrg94
approved these changes
Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder! For simplicity, please make sure that your pull request includes one and only one contribution.
Complete the Applicable Sections Below
Find which section best describes your pull request and make sure you fill it out. To start, let us know which issue you've fixed.
Code Snippets
Added/Updated <Sample Program> in <Language>formatDocumentation
Added/Updated <Sample Program> in <Language> ArticleformatTesting
Added/Updated <Language>/<Project> TestingformatNotes
Feel free to describe what you added or updated.