Added Baklava in C++ #1252
Merged
Added Baklava in C++ #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrg94
added
baklava
jrg94
requested changes
Oct 9, 2019
There was a problem hiding this comment.
Nice work! I took a peek at the test suite, and it looks like this solution fails with the following error:
__________________________ test_baklava[baklava.cpp] ___________________________
baklava = Source(name: baklava, path: /home/travis/build/TheRenegadeCoder/sample-programs/archive/c/c-plus-plus
def test_baklava(baklava):
expected = """ *
***
*****
*******
*********
***********
*************
***************
*****************
*******************
*********************
*******************
*****************
***************
*************
***********
*********
*******
*****
***
*
"""
expected_lines = expected.split(os.linesep)
actual = baklava.run()
actual_lines = actual.split(os.linesep)
for i in range(len(expected_lines)):
> assert actual_lines[i] == expected_lines[i], f'line {i + 1} did not match'
E AssertionError: line 1 did not match
E assert 'sh: 1: pause: not found' == ' *'
E - sh: 1: pause: not found
E + *
test/projects/test_baklava.py:45: AssertionError
================== 1 failed, 608 passed in 237.33s (0:03:57) ===================
The command "python -um samplerunner test" exited with 1.
Any chance you could look into this?
|
I just make it static to pass the test but I could not run the test. requests.exceptions.ConnectionError: ('Connection aborted.', PermissionError(13, 'Permission denied')) it seems it happens during connecting to docker |
|
That's a good question. Best for @auroq. That said, you can always check the results in Travis CI: https://travis-ci.com/TheRenegadeCoder/sample-programs/jobs/244981574 It looks like there's one too many spaces in the first row. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete the Applicable Sections Below
Find which section best describes your pull request and make sure you fill it out. To start, let us know which issue you've fixed.
Code Snippets
Added/Updated <Sample Program> in <Language>formatDocumentation
Added/Updated <Sample Program> in <Language> ArticleformatTesting
Added/Updated <Language>/<Project> TestingformatNotes
Feel free to describe what you added or updated.