Project: Recipes: Add creation of backlink to recipes tutorial #29238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add instructions for back link from recipes to homepage (index.html)
github-actions
bot
added
the
Content: Foundations
rlmoser99
requested review from
a team and
zachmmeyer
and removed request for
a team
zachmmeyer
requested changes
Dec 28, 2024
There was a problem hiding this comment.
Hello there! Thank you for contributing.
You checked off several items in the PR description. Here are three of them that I'd like to call out:
- The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
- If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
- The Because section summarizes the reason for this PR
Please go over these bullet points and make sure you're adhering to the guidelines you agreed to. I'd look at some of the other active or merged PRs.
Thanks!
Keiferton
changed the title
|
Thank you Zach! I've addressed the issues and will update shortly. E: updated |
fix typo and use correct markdown syntax for backlink html example
zachmmeyer
approved these changes
Dec 29, 2024
zachmmeyer
requested changes
Dec 29, 2024
- add blank line before and after fenced html - ignore capitalization, html is not used as a noun here
|
@Keiferton looks like the linter caught another issue. |
the linter showed an error on line 71, I believe it to be from a line break on an indented line, removed indent
zachmmeyer
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add instructions for back link from recipes to homepage (index.html)
Because
In Project: Recipes, adding instructions for how to back link to index.html, can make it so beginners can easily navigate while they are changing their pages. Tutorial doesn't explicitly recommend to do this, so this could be helpful.
This PR
Issue
Closes #XXXXX
Additional Information
Pull Request Requirements
location of change: brief description of changeformat, e.g.Intro to HTML and CSS lesson: Fix link textBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection