Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flex/03-flex-header-2: fixed links not leading to desired URL #498

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

ojuliocode
Copy link
Contributor

@ojuliocode ojuliocode commented Feb 28, 2024

Because

Links didn't have https, so they weren't leading to the desired url

This PR

  • Insert https into href of tags

Issue

Closes #453

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. 01-flex-center: Update self check
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If applicable, I have ensured that the TOP solution files match the Desired Outcome image

@thatblindgeye thatblindgeye merged commit 80b7354 into TheOdinProject:main Feb 29, 2024
TeamPlatinum1 pushed a commit to TeamPlatinum1/css-exercises that referenced this pull request Sep 3, 2024
flex/03-flex-header-2: fixed links not leading to desired URL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug - Flexbox exercises:<a> tags linked to google.com don't go to google
2 participants