Remove unnecessary heap allocation in heap data structure implementation #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnshulMalik
approved these changes
Oct 6, 2020
kczimm
pushed a commit
to kczimm/Rust
that referenced
this pull request
Oct 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation of heap, min-heap and max-heap are using closures which are allocated dynamically on heap memory for comparing elements. However, they are not necessary to be closures here because a comparison predicate of heap data structure does not have its state. It's a pure function which takes two elements and returns boolean value. For such case, simply a function pointer is appropriate. It does not require any heap allocation.