Fix clippy warnings #113
Merged
Fix clippy warnings #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boydjohnson
force-pushed
the
fix-clippy-warnings
branch
from
34a254b to
9d3d2a8
Compare
Allows MinHeap and MaxHeap new methods to return Heap Fixes incorrect is_empty() implementation. is_empty should return true when self.len() == 0.
boydjohnson
force-pushed
the
fix-clippy-warnings
branch
from
9d3d2a8 to
c536650
Compare
This changes to use -= instead of manually implementing. Removes a lifetime that can be elided.
boydjohnson
force-pushed
the
fix-clippy-warnings
branch
from
c536650 to
54fef2c
Compare
|
Hi @AnshulMalik, There were a small amount of clippy lint that |
AnshulMalik
approved these changes
Jan 24, 2021
|
Thanks @boydjohnson |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR there will be CI failures on clippy warnings. I think this gives greater guarantees of idiomatic code.