Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check whether integer is even or odd using bit manupulation #7099

Merged
merged 8 commits into from
Oct 23, 2022
Merged

check whether integer is even or odd using bit manupulation #7099

merged 8 commits into from
Oct 23, 2022

Conversation

Lauquik
Copy link
Contributor

@Lauquik Lauquik commented Oct 13, 2022

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 13, 2022
CaedenPH
CaedenPH approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@CaedenPH CaedenPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@CaedenPH
Copy link
Contributor

@luciferx48
I forgot to mention, could you add the algorithm to the DIRECTORY.md file please

@Lauquik
Copy link
Contributor Author

Lauquik commented Oct 13, 2022

@CaedenPH thnx for reviewing, Directory.md updated

CaedenPH
CaedenPH requested changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@CaedenPH CaedenPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the DIRECTORY.md, algorithms should be in alphabetical order

@Lauquik
Copy link
Contributor Author

Lauquik commented Oct 13, 2022

Oops! Sorry I forgot , changes has been committed successfully

@Lauquik Lauquik requested a review from CaedenPH October 13, 2022 13:14
@Lauquik Lauquik requested a review from CaedenPH October 23, 2022 12:28
CaedenPH
CaedenPH approved these changes Oct 23, 2022
View reviewed changes
Copy link
Contributor

@CaedenPH CaedenPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cclauss Can we get your review?

@Lauquik
Copy link
Contributor Author

Lauquik commented Oct 23, 2022

@cclauss can you merge or close this PR

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 23, 2022
@cclauss cclauss merged commit 39a99b4 into TheAlgorithms:master Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaedenPH CaedenPH CaedenPH approved these changes

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lauquik @CaedenPH @cclauss