Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Code #6126

Merged
merged 11 commits into from
May 13, 2022
Merged

Improve Code #6126

merged 11 commits into from
May 13, 2022

Conversation

Ombucha
Copy link
Contributor

@Ombucha Ombucha commented May 6, 2022

Describe your change:

This PR improves overall code

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels May 6, 2022
@poyea poyea self-assigned this May 12, 2022
@ghost ghost added the tests are failing Do not merge until tests pass label May 12, 2022
@Ombucha
Copy link
Contributor Author

Ombucha commented May 13, 2022

@poyea Can this PR be merged?

@ghost ghost removed the tests are failing Do not merge until tests pass label May 13, 2022
poyea
poyea approved these changes May 13, 2022
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@poyea poyea merged commit dbee5f0 into TheAlgorithms:master May 13, 2022
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea poyea approved these changes

@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees

@poyea poyea

Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ombucha @poyea