Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for class CountChar. #3334

Merged
merged 9 commits into from
Oct 12, 2022
Merged

Test for class CountChar. #3334

merged 9 commits into from
Oct 12, 2022

Conversation

ricardo-ramos-moura
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

aitorfi
aitorfi suggested changes Oct 9, 2022
View reviewed changes
Copy link
Contributor

@aitorfi aitorfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the main method from the CountChar class as the test already demonstrates the algorithm works. Remove the changes made to the DudeneyNumber class as they belong to the PR #3327

aitorfi
aitorfi suggested changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@aitorfi aitorfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the changes made to the DudeneyNumber class as they belong to the PR #3327 and resolve the merge conflicts please.

aitorfi
aitorfi reviewed Oct 12, 2022
View reviewed changes
Copy link
Contributor

@aitorfi aitorfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

siriak
siriak approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak enabled auto-merge (squash) October 12, 2022 18:40
@siriak siriak merged commit c805437 into TheAlgorithms:master Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aitorfi aitorfi aitorfi requested changes

@siriak siriak siriak approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ricardo-ramos-moura @siriak @aitorfi