Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Action: Compile modified files with g++ #677

Merged
merged 7 commits into from
Dec 4, 2019
Merged

GitHub Action: Compile modified files with g++ #677

merged 7 commits into from
Dec 4, 2019

Conversation

cclauss
Copy link
Member

@cclauss cclauss commented Dec 3, 2019

DO NOT MERGE.

Description of Change

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • Sort by alphabetical order
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

cclauss
cclauss commented Dec 4, 2019
View reviewed changes
.github/workflows/cpplint_modified_files.yml Outdated
g++ -v
ls
# g++ backtracking/n_queens.cpp
g++ **/*.cpp
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhaumikmistry Should we add a final step to .github/workflows/cpplint_modified_files.yml that attempts to g++ compile all .cpp files that have been modified?

@cclauss cclauss added the on hold Pull request is temporarily not reviewed label Dec 4, 2019
@cclauss cclauss changed the title WIP: g++ backtracking/n_queens.cpp GitHub Action: Compile modified files with g++ Dec 4, 2019
@cclauss cclauss merged commit b64e8fb into master Dec 4, 2019
@cclauss cclauss deleted the g++-backtracking/n_queens.cpp branch December 4, 2019 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
on hold Pull request is temporarily not reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cclauss