Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Digit Separation Algorithm added #2759

Merged
merged 28 commits into from
Oct 7, 2024
Merged

feat: Digit Separation Algorithm added #2759

merged 28 commits into from
Oct 7, 2024

Conversation

mjk22071998
Copy link
Contributor

Added Digit Separation Algorithm for large numbers

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

realstealthninja
realstealthninja requested changes Oct 5, 2024
View reviewed changes
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for your contribution!
some issues to address:

Code isn't documented properly.

  • includes should be documented
  • namespaces should be documented

greedy_algorithms/digit_separation.cpp Outdated Show resolved Hide resolved
greedy_algorithms/digit_separation.cpp Outdated Show resolved Hide resolved
greedy_algorithms/digit_separation.cpp Outdated Show resolved Hide resolved
@realstealthninja realstealthninja added awaiting modification Do not merge until modifications are made Proper Documentation Required requested to write the documentation properly labels Oct 5, 2024
@mjk22071998
"Updated digit separation code: added comments and docstrings, change…
76edb15 
…d data types to std::int64_t, and reformatted code."
realstealthninja
realstealthninja requested changes Oct 5, 2024
View reviewed changes
greedy_algorithms/digit_separation.cpp Outdated Show resolved Hide resolved
greedy_algorithms/digit_separation.cpp Show resolved Hide resolved
greedy_algorithms/digit_separation.cpp Show resolved Hide resolved
greedy_algorithms/digit_separation.cpp Outdated Show resolved Hide resolved
realstealthninja and others added 2 commits October 5, 2024 17:09
@realstealthninja
fix: terminate multiline comment
d3edb52
@mjk22071998 @realstealthninja
Update greedy_algorithms/digit_separation.cpp
1fb86db 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
realstealthninja
realstealthninja requested changes Oct 5, 2024
View reviewed changes
greedy_algorithms/digit_separation.cpp Outdated Show resolved Hide resolved
greedy_algorithms/digit_separation.cpp Show resolved Hide resolved
greedy_algorithms/digit_separation.cpp Outdated Show resolved Hide resolved
greedy_algorithms/digit_separation.cpp Outdated Show resolved Hide resolved
mjk22071998 and others added 4 commits October 5, 2024 16:43
@mjk22071998 @realstealthninja
Update greedy_algorithms/digit_separation.cpp
ad03474 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@mjk22071998 @realstealthninja
Update greedy_algorithms/digit_separation.cpp
5f392b9 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@mjk22071998 @realstealthninja
Update greedy_algorithms/digit_separation.cpp
373e1df 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@mjk22071998
Corrected test function
af077d2
@realstealthninja
Copy link
Collaborator

Hey thank you for your contribution. Is this for hacktoberfest?

realstealthninja
realstealthninja requested changes Oct 5, 2024
View reviewed changes
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! 🚀

greedy_algorithms/digit_separation.cpp Outdated Show resolved Hide resolved
greedy_algorithms/digit_separation.cpp Outdated Show resolved Hide resolved
@mjk22071998
Copy link
Contributor Author

Yes this is for hacktoberfest

mjk22071998 and others added 2 commits October 5, 2024 16:49
@mjk22071998 @realstealthninja
Update greedy_algorithms/digit_separation.cpp
18b6546 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@mjk22071998 @realstealthninja
Update greedy_algorithms/digit_separation.cpp
87b955b 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
realstealthninja
realstealthninja requested changes Oct 5, 2024
View reviewed changes
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format your code with clang-tidy/clang-format

greedy_algorithms/digit_separation.cpp Outdated Show resolved Hide resolved
greedy_algorithms/digit_separation.cpp Show resolved Hide resolved
mjk22071998 and others added 2 commits October 5, 2024 17:22
@mjk22071998 @realstealthninja
remove redundant declaration
a585834 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@mjk22071998 @realstealthninja
Corrected tests
ef954a8 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@realstealthninja
Copy link
Collaborator

you should lint this file with clang-format

@mjk22071998
Copy link
Contributor Author

I formatted it

@mjk22071998 @realstealthninja
fowardOrder to forwardOrder on line 122
ba56880 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
realstealthninja
realstealthninja requested changes Oct 6, 2024
View reviewed changes
greedy_algorithms/digit_separation.cpp Outdated Show resolved Hide resolved
greedy_algorithms/digit_separation.cpp Outdated Show resolved Hide resolved
mjk22071998 and others added 2 commits October 6, 2024 08:03
@mjk22071998 @realstealthninja
Removed Class scope resolution form digitSeparationReverseOrder function
40ac103 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@mjk22071998 @realstealthninja
Removed Class scope resolution form digitSeparationForwardOrderfunction
12d8d53 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
realstealthninja
realstealthninja requested changes Oct 6, 2024
View reviewed changes
greedy_algorithms/digit_separation.cpp Outdated Show resolved Hide resolved
greedy_algorithms/digit_separation.cpp Outdated Show resolved Hide resolved
greedy_algorithms/digit_separation.cpp Outdated Show resolved Hide resolved
realstealthninja
realstealthninja approved these changes Oct 6, 2024
View reviewed changes
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for this.

@realstealthninja realstealthninja added approved Approved; waiting for merge hacktoberfest-accepted Accepted to be counted towards Hacktoberfest and removed awaiting modification Do not merge until modifications are made Proper Documentation Required requested to write the documentation properly labels Oct 6, 2024
@mjk22071998
Copy link
Contributor Author

I want to contribute more, but I am new to open source so, I am confused if I perform a new commit will that be a part of this PR by default or not? As for new contribution, I want to open a new pull request as recommended.

@realstealthninja
Copy link
Collaborator

Create a new branch from master in your fork and make changes then create a pr

@realstealthninja realstealthninja merged commit dd36279 into TheAlgorithms:master Oct 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realstealthninja realstealthninja realstealthninja approved these changes

@Panquesito7 Panquesito7 Awaiting requested review from Panquesito7 Panquesito7 is a code owner

Assignees
No one assigned
Labels
approved Approved; waiting for merge hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjk22071998 @realstealthninja