feat: add Kelvin to Celsius conversion algorithm #2475
Conversation
|
|
||
| #include <cassert> /// for assert | ||
| #include <cmath> /// for std::abs | ||
| #include <iostream> /// for IO operations |
There was a problem hiding this comment.
| #include <iostream> /// for IO operations | |
| #include <iostream> /// for std::cout |
There was a problem hiding this comment.
IO operations is perfectly valid as we are doing input and output operations. And this is also how the documentation specifies
There was a problem hiding this comment.
@realstealthninja please have a look here.
There was a problem hiding this comment.
I/O operations cout is an output operation it makes sense to me. You have to understand that if you want a change you don't do it through precedents because precedents are repelled and lost to time. If you want change create a discussion on it and if enough people agree it will be written into contribution.md. i am merely a man of the document it would be a much more useful debate if it was on the discussion board
There was a problem hiding this comment.
Personally, I don't think either should exist 🤷🏼. It is perfectly clear to every c++ programmer that starts out with a "Hello world" program what iostream is 😄 (just my 2 pennies)
others/kelvin_to_celsius.cpp
Outdated
| static void tests() { | ||
| assert(others::are_equal(others::kelvin_to_celsius(230), -43.15)); | ||
| assert(others::are_equal(others::kelvin_to_celsius(512), 238.85)); | ||
| assert(others::are_equal(others::kelvin_to_celsius(-452), -725.15)); |
There was a problem hiding this comment.
i have to say this is a such a simple yet intuitive way to do tests its clear simple and precise ❤️
Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
Co-authored-by: Piotr Idzik <vil02@users.noreply.github.com>
|
|
||
| #include <cassert> /// for assert | ||
| #include <cmath> /// for std::abs | ||
| #include <iostream> /// for IO operations |
There was a problem hiding this comment.
Personally, I don't think either should exist 🤷🏼. It is perfectly clear to every c++ programmer that starts out with a "Hello world" program what iostream is 😄 (just my 2 pennies)
Description of Change
Checklist
Notes: