Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add codeowners #2474

Merged
merged 2 commits into from
May 31, 2023
Merged

chore: add codeowners #2474

merged 2 commits into from
May 31, 2023

Conversation

Panquesito7
Copy link
Member

@Panquesito7 Panquesito7 commented May 30, 2023

Description of Change

  • Add codeowners.
    • These are the current most active C++ maintainers. If some get inactive or active, we can remove them from the list, but that doesn't mean that they're not maintainers anymore.
    • This will request a review for those on the list in every PR.
    • If you wish to be added/removed from the list, let me know. 🙂

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@Panquesito7 Panquesito7 added the enhancement New feature or request label May 30, 2023
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love to see this list grow big someday ❤️

@github-actions github-actions bot added the approved Approved; waiting for merge label May 31, 2023
@Panquesito7 Panquesito7 merged commit ea4100e into master May 31, 2023
@Panquesito7 Panquesito7 deleted the add_codeowners branch May 31, 2023 17:51
@github-actions github-actions bot restored the add_codeowners branch May 31, 2023 17:51
@Panquesito7 Panquesito7 deleted the add_codeowners branch June 12, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved; waiting for merge enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants