Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: segv in longest_palindromic_subsequence.cpp #2461

Merged
merged 10 commits into from
May 18, 2023
Merged

fix: segv in longest_palindromic_subsequence.cpp #2461

merged 10 commits into from
May 18, 2023

Conversation

vil02
Copy link
Member

@vil02 vil02 commented May 11, 2023 •
edited
Loading

Description of Change

This PR:

  • fixes the segmentation fault caused by not fully initializing res,
  • fixes the fact that ans was containing an extra null character,
  • b9d84fb stops -Wconversion from rasing a warning,
  • some minor style improvements.

Checklist

  • Added description of change
  • Added tests and example, test must pass
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:
fixes segv in longest_palindromic_subsequence.cpp

@Panquesito7 Panquesito7 added the bugfix Correction to existing algorithms label May 16, 2023
Panquesito7
Panquesito7 approved these changes May 18, 2023
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@Panquesito7 Panquesito7 merged commit 4fc1471 into TheAlgorithms:master May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panquesito7 Panquesito7 Panquesito7 approved these changes

Assignees
No one assigned
Labels
bugfix Correction to existing algorithms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vil02 @Panquesito7