Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Treap Data Structure #2458

Merged
merged 45 commits into from
Jul 21, 2023
Merged

feat: Treap Data Structure #2458

merged 45 commits into from
Jul 21, 2023

Conversation

fgmn
Copy link
Contributor

@fgmn fgmn commented May 7, 2023 •
edited
Loading

Description of Change

I added the treap data structure. It is a balanced binary search tree on the basis of binary search tree and heap.

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

realstealthninja
realstealthninja requested changes May 7, 2023
View reviewed changes
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contributions! please do adhere to the contributing guidelines!
❤️

data_structures/treap.cpp Outdated Show resolved Hide resolved
data_structures/treap.cpp Outdated Show resolved Hide resolved
data_structures/treap.cpp Outdated Show resolved Hide resolved
data_structures/treap.cpp Show resolved Hide resolved
data_structures/treap.cpp Outdated Show resolved Hide resolved
data_structures/treap.cpp Outdated Show resolved Hide resolved
data_structures/treap.cpp Outdated Show resolved Hide resolved
data_structures/treap.cpp Outdated Show resolved Hide resolved
data_structures/treap.cpp Outdated Show resolved Hide resolved
data_structures/treap.cpp Outdated Show resolved Hide resolved
fgmn and others added 17 commits May 7, 2023 21:44
@fgmn @realstealthninja
fix: suggested changes
bf190ca 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@fgmn @realstealthninja
fix: suggested changes
c72f945 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@fgmn @realstealthninja
fix: suggested changes
f6a1b0a 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@fgmn @realstealthninja
fix: suggested changes
f98c48c 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@fgmn @realstealthninja
fix: suggested changes
58727af 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@fgmn @realstealthninja
fix: suggested changes
ccc4895 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@fgmn @realstealthninja
fix: suggested changes
12a8356 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@fgmn @realstealthninja
fix: suggested changes
709863f 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@fgmn @realstealthninja
fix: suggested changes
f193452 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@fgmn @realstealthninja
fix: suggested changes
bf8b105 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@fgmn @realstealthninja
fix: suggested changes
23afd76 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@fgmn @realstealthninja
fix: suggested changes
6c01bc7 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@fgmn @realstealthninja
fix: suggested changes
cee2730 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@fgmn @realstealthninja
fix: suggested changes
9f4386a 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@fgmn @realstealthninja
fix: suggested changes
52605ce 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@fgmn @realstealthninja
fix: suggested changes
d76f48e 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@fgmn
fix: suggested changes
2c18a5f
@fgmn
Copy link
Contributor Author

fgmn commented May 7, 2023

thanks for careful guidances, I have fixed them according to the suggestion

realstealthninja
realstealthninja requested changes May 7, 2023
View reviewed changes
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a bit more!!!!

data_structures/treap.cpp Outdated Show resolved Hide resolved
data_structures/treap.cpp Outdated Show resolved Hide resolved
fgmn and others added 2 commits May 8, 2023 12:42
@fgmn @realstealthninja
fix: suggested changes
16f6cd1 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@fgmn
fix: add more self-tests
f5afed6
realstealthninja
realstealthninja previously approved these changes May 8, 2023
View reviewed changes
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you so much for contributing 🙂. The pr will be reviewed by maintainers soon!

@fgmn
Copy link
Contributor Author

fgmn commented May 8, 2023

LGTM! Thank you so much for contributing 🙂. The pr will be reviewed by maintainers soon!

thank you！🙂

@fgmn
Copy link
Contributor Author

fgmn commented May 16, 2023

Can someone look at me👀

@realstealthninja
Copy link
Collaborator

@Panquesito7 could you look at this please, sorry for the mention!

@fgmn @realstealthninja
fix: suggested changes
59c7c62 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
Panquesito7
Panquesito7 requested changes May 31, 2023
View reviewed changes
data_structures/treap.cpp Outdated Show resolved Hide resolved
Panquesito7
Panquesito7 approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks! 🚀

@fgmn
Copy link
Contributor Author

fgmn commented Jun 1, 2023

Great, thank you!🙂

@fgmn
Copy link
Contributor Author

fgmn commented Jun 14, 2023

@realstealthninja Execuse me, could you have a review🧡

1 similar comment
@fgmn
Copy link
Contributor Author

fgmn commented Jun 27, 2023

@realstealthninja Execuse me, could you have a review🧡

@realstealthninja
Copy link
Collaborator

So sorry didnt see this pull request!

realstealthninja
realstealthninja approved these changes Jun 27, 2023
View reviewed changes
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!!! Great work!

@fgmn
Copy link
Contributor Author

fgmn commented Jul 10, 2023

image
I meet this problem. Do you know how to fix it?

@fgmn
Copy link
Contributor Author

fgmn commented Jul 19, 2023

It's been so long that I can't remember what I contributed😂Is this pr still valid now?

@fgmn
Copy link
Contributor Author

fgmn commented Jul 19, 2023

image I meet this problem. Do you know how to fix it?

Is this because my limited privilege to this repo?

@fgmn
Copy link
Contributor Author

fgmn commented Jul 19, 2023

Sorry for taking up your time. This is the first time for me to come into contact with such a complete open source project, and I hope to get your answers @realstealthninja @Panquesito7 ❤️❤️❤️

@fgmn
Copy link
Contributor Author

fgmn commented Jul 19, 2023

Fetching the repository
/usr/local/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +refs/heads/gh-pages*:refs/remotes/origin/gh-pages* +refs/tags/gh-pages*:refs/tags/gh-pages*
The process '/usr/local/bin/git' failed with exit code 1
Waiting 14 seconds before trying again
/usr/local/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +refs/heads/gh-pages*:refs/remotes/origin/gh-pages* +refs/tags/gh-pages*:refs/tags/gh-pages*
The process '/usr/local/bin/git' failed with exit code 1
Waiting 17 seconds before trying again
/usr/local/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +refs/heads/gh-pages*:refs/remotes/origin/gh-pages* +refs/tags/gh-pages*:refs/tags/gh-pages*
Error: The process '/usr/local/bin/git' failed with exit code 1

Add some error messages

@realstealthninja
Copy link
Collaborator

Gh pages not being built is not really a fault with your code I'll run the workflows now to see if there is actually any build errors

@fgmn
Copy link
Contributor Author

fgmn commented Jul 20, 2023

@Panquesito7 Execuse me, could you have a review🧡

@realstealthninja
Copy link
Collaborator

the workflows have gone successfully! Thanks alot for the contributions.

@realstealthninja
Copy link
Collaborator

ill merge this in two days if there aren't any objections please ping me incase i forget 👍

@Panquesito7
Copy link
Member

@Panquesito7 Execuse me, could you have a review🧡

Sure, sorry, I've recently come back. 🙂

@Panquesito7 Panquesito7 merged commit 170f7e5 into TheAlgorithms:master Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realstealthninja realstealthninja realstealthninja approved these changes

@Panquesito7 Panquesito7 Panquesito7 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fgmn @realstealthninja @Panquesito7