Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Sieve of Eratosthenes (originally by @thechubbypanda) #2442

Merged
merged 2 commits into from
Mar 29, 2023
Merged

feat: add Sieve of Eratosthenes (originally by @thechubbypanda) #2442

merged 2 commits into from
Mar 29, 2023

Conversation

Panquesito7
Copy link
Member

@Panquesito7 Panquesito7 commented Mar 24, 2023 •
edited
Loading

Description of Change

  • Add Sieve of Eratosthenes.

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

Panquesito7 and others added 2 commits March 24, 2023 23:51
@Panquesito7
feat: add Sieve of Eratosthenes
1de2e57 
Originally created by @thechubbypanda.
Co-authored-by: Keval Kapdee <keval@thechubbypanda.net>
updating DIRECTORY.md
393e849
@Panquesito7 Panquesito7 added the enhancement New feature or request label Mar 24, 2023
alexpantyukhin
alexpantyukhin approved these changes Mar 25, 2023
View reviewed changes
Copy link
Member

@alexpantyukhin alexpantyukhin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Panquesito7 Panquesito7 merged commit 1d2c5d9 into TheAlgorithms:master Mar 29, 2023
@Panquesito7 Panquesito7 deleted the sieve_of_eratosthenes branch March 29, 2023 20:24
@Panquesito7 Panquesito7 mentioned this pull request Jun 16, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjgurwara99 tjgurwara99 tjgurwara99 approved these changes

@alexpantyukhin alexpantyukhin alexpantyukhin approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Panquesito7 @alexpantyukhin @tjgurwara99