Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Stooge sort algorithm #2440

Merged
merged 8 commits into from
Apr 14, 2023
Merged

feat: add Stooge sort algorithm #2440

merged 8 commits into from
Apr 14, 2023

Conversation

mindaugl
Copy link
Contributor

Description of Change

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@Panquesito7 Panquesito7 added the enhancement New feature or request label Mar 12, 2023
Panquesito7
Panquesito7 requested changes Mar 13, 2023
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the clang-tidy warnings.
Let us know if you need any help with that. 🙂

sorting/stooge_sort.cpp Outdated Show resolved Hide resolved
sorting/stooge_sort.cpp Outdated Show resolved Hide resolved
sorting/stooge_sort.cpp Show resolved Hide resolved
Panquesito7
Panquesito7 requested changes Mar 24, 2023
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are needed so that Doxygen detects the functions properly.

sorting/stooge_sort.cpp Show resolved Hide resolved
sorting/stooge_sort.cpp Show resolved Hide resolved
sorting/stooge_sort.cpp Show resolved Hide resolved
@Panquesito7 Panquesito7 added the automated tests are failing Do not merge until tests pass label Mar 24, 2023
@Panquesito7 Panquesito7 removed the automated tests are failing Do not merge until tests pass label Mar 30, 2023
Panquesito7
Panquesito7 reviewed Mar 30, 2023
View reviewed changes
sorting/stooge_sort.cpp Show resolved Hide resolved
sorting/stooge_sort.cpp Show resolved Hide resolved
Panquesito7
Panquesito7 previously approved these changes Apr 10, 2023
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks! 🚀

tjgurwara99
tjgurwara99 requested changes Apr 12, 2023
View reviewed changes
sorting/stooge_sort.cpp Outdated Show resolved Hide resolved
@Panquesito7 Panquesito7 merged commit 29f5439 into TheAlgorithms:master Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexpantyukhin alexpantyukhin alexpantyukhin left review comments

@Panquesito7 Panquesito7 Panquesito7 approved these changes

@tjgurwara99 tjgurwara99 tjgurwara99 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mindaugl @alexpantyukhin @tjgurwara99 @Panquesito7