Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove memory leak in queue #2417

Merged
merged 10 commits into from
Jan 26, 2023

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Jan 11, 2023

Description of Change

Main reason for this PR is to fix a memory leak in queue.h. The changes are similar as in #2235, i.e.:

Furthermore:

  • some typos were fixed,
  • The Node class and related utilities have their own file .

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:
Fixes the memory leak in queue.h

@Panquesito7 Panquesito7 added the bugfix Correction to existing algorithms label Jan 13, 2023
data_structures/queue.hpp Outdated Show resolved Hide resolved
@vil02 vil02 requested a review from Panquesito7 January 13, 2023 21:18
@vil02 vil02 mentioned this pull request Jan 14, 2023
5 tasks
Panquesito7
Panquesito7 previously approved these changes Jan 22, 2023
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks! 🚀

@Panquesito7 Panquesito7 merged commit 7c09048 into TheAlgorithms:master Jan 26, 2023
@Panquesito7 Panquesito7 added the Improvement improvement in previously written codes label Jan 26, 2023
@vil02 vil02 deleted the queue_memory_leak_patch branch January 27, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Correction to existing algorithms Improvement improvement in previously written codes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants