-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add k-nearest neighbors algorithm #2416
feat: add k-nearest neighbors algorithm #2416
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work! Thank you so much. 🚀
Thank you! When I have more spare time I'm thinking of contributing more machine learning algorithms. I'm taking a class in college about machine learning and it's really cool to implement the algorithms in languages like Cpp. Hope you like it! |
Hey @Panquesito7 , I was looking at the organization's repositories and had a question. Some machine learning algorithms can be used for both classification and regression tasks, such as K-Nearest Neighbors or Decision Trees. At TheAlgorithms/Python, there seems to be some distinction in the filenames, but not very clear. That said, it would make sense to rename the file here like Although the core algorithm is the same, when applied to a regression task the final algorithm has some differences from the one applied to a classification task. E.g: KNeighborsRegressor and KNeighborsClassifier |
I think it's fine to keep the name as-is, not sure what the others think, though. |
Description of Change
Checklist
Notes: