Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strassen's Matrix Multiplication #2413

Merged
merged 17 commits into from
Jan 24, 2023
Merged

Strassen's Matrix Multiplication #2413

merged 17 commits into from
Jan 24, 2023

Conversation

AshishYUO
Copy link
Contributor

Description of Change

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@Panquesito7 Panquesito7 added the enhancement New feature or request label Dec 29, 2022
Panquesito7
Panquesito7 requested changes Dec 29, 2022
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🚀 Will check the code later on.

divide_and_conquer/strassen_matrix_multiplication.cpp Outdated Show resolved Hide resolved
divide_and_conquer/strassen_matrix_multiplication.cpp Outdated Show resolved Hide resolved
divide_and_conquer/strassen_matrix_multiplication.cpp Outdated Show resolved Hide resolved
divide_and_conquer/strassen_matrix_multiplication.cpp Outdated Show resolved Hide resolved
@Panquesito7 Panquesito7 self-requested a review December 30, 2022 06:33
@AshishYUO
Copy link
Contributor Author

@Panquesito7 The changes are done. Let me know if it needs more corrections.

Panquesito7
Panquesito7 previously approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good work. Thanks! 🚀
The only thing I saw is that it takes quite a long time to compile (used the Gitpod ready-to-code service). Is this normal?

image

If so, you might want to add a note for that in the code or in a print statement.

@AshishYUO
Copy link
Contributor Author

I usually test the code with optimize flags. I never thought this would actually run that much slow without the flags.
I have reduced the size of the matrix at the moment, it'll now take at most 4-5 seconds.

tjgurwara99
tjgurwara99 previously approved these changes Jan 18, 2023
View reviewed changes
Panquesito7
Panquesito7 approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better on time! Thanks. 🚀

@Panquesito7 Panquesito7 merged commit 5b23872 into TheAlgorithms:master Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panquesito7 Panquesito7 Panquesito7 approved these changes

@tjgurwara99 tjgurwara99 tjgurwara99 left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AshishYUO @tjgurwara99 @Panquesito7 @ashishdaulatabad