feat: add power of two algorithm #2224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Panquesito7
added
enhancement
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
added
the
stale
Panquesito7
removed
the
automated tests are failing
tjgurwara99
previously approved these changes
Feb 1, 2023
krishnacx
reviewed
Feb 2, 2023
| * @namespace bit_manipulation | ||
| * @brief Bit manipulation algorithms | ||
| */ | ||
| namespace bit_manipulation { |
There was a problem hiding this comment.
Why 2 namespaces are required ? Is it like you would add more algorithms in this file ?
There was a problem hiding this comment.
Only two namespaces are required in case there are a lot of functions. But in this case, it's only one function, so having one namespace should suffice.
krishnacx
previously approved these changes
Feb 2, 2023
Panquesito7
dismissed stale reviews from krishnacx and tjgurwara99
via
df16aa4
Panquesito7
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new CPU-Scheduling Algorithm Shortest Job First