-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boruvkas Algorithm #1984
Boruvkas Algorithm #1984
Conversation
Implemented Boruvkas Algorithm under graphs as a means for finding the minimums spanning tree
Implemented Boruvkas algorithm, a greedy algorithm to find a graphs minimum spanning tree.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 🚀
There are still a few other pending things to do. If you need any help, let us know here or in our Discord community. 🙂
limits.h to climits Co-authored-by: David Leal <halfpacho@gmail.com>
Made changes as recommended by Panquesito7 for maintainability and security
Made suggested changes Co-authored-by: David Leal <halfpacho@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! 😄
Changed from graph to greedy algorithm, removed the extra main(), general fixes
… into Boruvkas-Algo
General readability changes, change push_back to implace_back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the clang-tidy
warnings here.
Let us know if you need any help with that! 🙂
Added pre-allocation of memory for the parent vector of Boruvkas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the filename: there's a spelling error (u
-> i
).
Old: boruvkas_minumum_spanning_tree.cpp
New: boruvkas_minimum_spanning_tree.cpp
Fixed file name, added Boruvkas namespace, made suggested changes
Fixed spacing hopefully
Fixing weird tabs
Finally done with spacing i think
Triplle checked tabs/spaces
604ba43
to
1562db7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. Thanks! 🚀
Description of Change
Implemented Boruvkas Algorithm, a greedy algorithm for finding a graphs minimums spanning tree.
Checklist
Notes: Implementation to greedily finds the Minimum Spanning Tree of a graph using Boruvka's algorithm.