feat: move gram_schmidt to numerical_methods
#1940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Numerical methods already contains and uses linear algebra methods. Graham Schmidt doesn't need its own folder.
poyea
approved these changes
Mar 17, 2022
|
Does this break any other code in this repo? |
poyea
changed the title
|
This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
|
@Panquesito7 your review, please. |
github-actions
bot
removed
the
stale
|
This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
|
Please ping one of the maintainers once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to ask for help in our Gitter channel or our Discord server. Thank you for your contributions! |
Panquesito7
removed
the
stale
Panquesito7
approved these changes
Jun 9, 2022
Panquesito7
changed the title
gram_schmidt to numerical_methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Numerical methods already contains and uses linear algebra methods. Graham Schmidt doesn't need its own folder. I moved graham_schmidt.cpp to numerical_methods and deleted linear_algebra. An alternate option would be further compartmentalization of numerical methods into it's subjects: linear algebra, PDEs, etc.
Checklist
Notes:
This file was authored by @Akanksha-Gupta920 so I would prefer his input.