Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Reworked interpolation_search.cpp #1855

Merged
merged 12 commits into from
Jan 2, 2022
Merged

feat: Reworked interpolation_search.cpp #1855

merged 12 commits into from
Jan 2, 2022

Conversation

Lazeeez
Copy link
Contributor

@Lazeeez Lazeeez commented Dec 18, 2021 •
edited by gitpod-io bot
Loading

Description of Change

The original interpolation_search.cpp was pretty blatant with little to no documentation, did some rework on it and added a testcase to check the algorithm.

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes: Did some rework on the original interpolation_search.cpp

@Lazeeez
Copy link
Contributor Author

Lazeeez commented Dec 18, 2021

@Panquesito7 Can you please review this PR, thanks!

@Panquesito7 Panquesito7 added the enhancement New feature or request label Dec 19, 2021
Panquesito7
Panquesito7 requested changes Dec 19, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🚀
Please enable GitHub Actions in your repository of this fork in this link: https://github.com/Lazeeez/C-Plus-Plus/actions

search/interpolation_search.cpp Outdated Show resolved Hide resolved
search/interpolation_search.cpp Outdated Show resolved Hide resolved
search/interpolation_search.cpp Outdated Show resolved Hide resolved
search/interpolation_search.cpp Outdated Show resolved Hide resolved
search/interpolation_search.cpp Outdated Show resolved Hide resolved
@Panquesito7 Panquesito7 added the requested changes changes have been requested label Dec 19, 2021
Lazeeez and others added 4 commits December 19, 2021 14:29
@Lazeeez @Panquesito7
Update search/interpolation_search.cpp
d32cd39 
Co-authored-by: David Leal <halfpacho@gmail.com>
@Lazeeez @Panquesito7
Update search/interpolation_search.cpp
c716430 
Co-authored-by: David Leal <halfpacho@gmail.com>
@Lazeeez @Panquesito7
Update search/interpolation_search.cpp
befc191 
Co-authored-by: David Leal <halfpacho@gmail.com>
@Lazeeez @Panquesito7
Update search/interpolation_search.cpp
d4eac66 
Co-authored-by: David Leal <halfpacho@gmail.com>
@github-actions github-actions bot force-pushed the interpolation_search branch 2 times, most recently from aa71c34 to e135d5f Compare December 19, 2021 09:00
@github-actions github-actions bot force-pushed the interpolation_search branch from e135d5f to 47b1163 Compare December 19, 2021 09:00
@Lazeeez Lazeeez requested a review from Panquesito7 December 19, 2021 09:01
@Lazeeez @Panquesito7
Update search/interpolation_search.cpp
2307643 
Co-authored-by: David Leal <halfpacho@gmail.com>
@Lazeeez
Copy link
Contributor Author

Lazeeez commented Dec 19, 2021

Great work! 🚀 Please enable GitHub Actions in your repository of this fork in this link: https://github.com/Lazeeez/C-Plus-Plus/actions

The Github actions are already enabled for this entire repository.

@Lazeeez
Copy link
Contributor Author

Lazeeez commented Dec 19, 2021

@Panquesito7 check now.

Panquesito7
Panquesito7 requested changes Dec 20, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! 😄

search/interpolation_search.cpp Show resolved Hide resolved
search/interpolation_search.cpp Outdated Show resolved Hide resolved
@Lazeeez Lazeeez requested a review from Panquesito7 December 22, 2021 12:09
Panquesito7
Panquesito7 requested changes Dec 23, 2021
View reviewed changes
search/interpolation_search.cpp Show resolved Hide resolved
search/interpolation_search.cpp Outdated Show resolved Hide resolved
search/interpolation_search.cpp Outdated Show resolved Hide resolved
@Lazeeez Lazeeez requested a review from Panquesito7 December 23, 2021 13:01
@Lazeeez @Panquesito7
Update search/interpolation_search.cpp
c1334ec 
Co-authored-by: David Leal <halfpacho@gmail.com>
@Lazeeez Lazeeez requested a review from Panquesito7 December 24, 2021 10:31
Panquesito7
Panquesito7 approved these changes Dec 25, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thank you for your contribution! 😄👍

@Panquesito7 Panquesito7 requested a review from aminoxix December 25, 2021 01:49
@Panquesito7 Panquesito7 added approved Approved; waiting for merge and removed requested changes changes have been requested labels Dec 25, 2021
ayaankhan98
ayaankhan98 approved these changes Jan 1, 2022
View reviewed changes
Copy link
Member

@ayaankhan98 ayaankhan98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Panquesito7 Panquesito7 merged commit 19f48ae into TheAlgorithms:master Jan 2, 2022
@Panquesito7 Panquesito7 changed the title feat: Reworked interpolation_search.cpp feat: Reworked interpolation_search.cpp Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panquesito7 Panquesito7 Panquesito7 approved these changes

@Qannaf Qannaf Qannaf approved these changes

@ayaankhan98 ayaankhan98 ayaankhan98 approved these changes

@aminoxix aminoxix Awaiting requested review from aminoxix

@mishraabhinn mishraabhinn Awaiting requested review from mishraabhinn

Assignees
No one assigned
Labels
approved Approved; waiting for merge enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Lazeeez @ayaankhan98 @Qannaf @Panquesito7