Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: documentation improvements in search/linear_search.cpp #1641

Merged
merged 7 commits into from
Jan 27, 2022

Conversation

ritikaa17
Copy link
Contributor

@ritikaa17 ritikaa17 commented Oct 2, 2021

Update readability of code

Description of Change

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

search/linear_search.cpp Outdated Show resolved Hide resolved
search/linear_search.cpp Outdated Show resolved Hide resolved
@Panquesito7 Panquesito7 added the Improvement improvement in previously written codes label Oct 10, 2021
@Panquesito7 Panquesito7 changed the title Update linear_search.cpp docs: documentation improvements in search/linear_search.cpp Oct 10, 2021
Qannaf
Qannaf previously approved these changes Jan 1, 2022
Copy link

@arunabh-cloud arunabh-cloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
May I suggest some improvements to this code?
Thanks.

@@ -32,7 +35,7 @@ int main() {
int *array = new int[size];
int key;

// Input array
/*User gets to input array elements*/
std::cout << "\nEnter the Array of " << size << " numbers : ";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a check for the user entering a negative number or a very large number as "size" of the array of numbers.

Panquesito7
Panquesito7 previously approved these changes Jan 20, 2022
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thank you for your contribution! 😄👍

@Panquesito7 Panquesito7 added the approved Approved; waiting for merge label Jan 20, 2022
Copy link
Member

@mishraabhinn mishraabhinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide the test cases also @ritikaa17. Thanks

mishraabhinn
mishraabhinn previously approved these changes Jan 20, 2022
@Panquesito7 Panquesito7 merged commit 18e8625 into TheAlgorithms:master Jan 27, 2022
arunabh-cloud added a commit to arunabh-cloud/C-Plus-Plus that referenced this pull request Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved; waiting for merge Improvement improvement in previously written codes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants