feat: Modified count_set_bits.cpp #1634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Panquesito7
requested changes
Oct 5, 2021
Panquesito7
added
automated tests are failing
Panquesito7
requested changes
Oct 6, 2021
Comment on lines
17
to
18
| #include <cassert> // for assert | ||
| #include <iostream> // for I/O operations |
There was a problem hiding this comment.
Suggested change
| #include <cassert> // for assert | |
| #include <iostream> // for I/O operations | |
| #include <cassert> /// for assert | |
| #include <iostream> /// for IO operations |
Comment on lines
25
to
29
| * @namespace count_of_set_bits | ||
| * @brief Functions for the [count sets | ||
| * bits](https://www.geeksforgeeks.org/count-set-bits-in-an-integer/) | ||
| * implementation | ||
| */ |
There was a problem hiding this comment.
Suggested change
| * @namespace count_of_set_bits | |
| * @brief Functions for the [count sets | |
| * bits](https://www.geeksforgeeks.org/count-set-bits-in-an-integer/) | |
| * implementation | |
| */ | |
| * @namespace count_of_set_bits | |
| * @brief Functions for the [count sets | |
| * bits](https://www.geeksforgeeks.org/count-set-bits-in-an-integer/) | |
| * implementation | |
| */ |
Comment on lines
78
to
82
| int main() | ||
| { | ||
| test(); // run self-test implementations | ||
| return 0; | ||
| } | ||
| } |
There was a problem hiding this comment.
Please fix the indentation in this part of the code.
Panquesito7
changed the title
Panquesito7
reviewed
Oct 6, 2021
| * We are given an integer number. Let’s say, number. The task is to first | ||
| * calculate the binary digit of a number and then calculate the total set bits | ||
| * of a number. | ||
| * We are given a integer number. We need to calculate number of set bits in it. |
There was a problem hiding this comment.
Suggested change
| * We are given a integer number. We need to calculate number of set bits in it. | |
| * We are given an integer number. We need to calculate the number of set bits in it. |
| * bits](https://www.geeksforgeeks.org/count-set-bits-in-an-integer/) in an | ||
| * integer. | ||
| * @brief Implementation to [count number of set bits of a number] | ||
| * (https://www.geeksforgeeks.org/count-set-bits-in-an-integer/) |
There was a problem hiding this comment.
Suggested change
| * (https://www.geeksforgeeks.org/count-set-bits-in-an-integer/) | |
| * (https://www.geeksforgeeks.org/count-set-bits-in-an-integer/) in an | |
| * integer. |
Co-authored-by: David Leal <halfpacho@gmail.com>
Panquesito7
reviewed
Oct 8, 2021
Co-authored-by: David Leal <halfpacho@gmail.com>
Panquesito7
removed
the
Proper Documentation Required
Panquesito7
reviewed
Oct 8, 2021
Co-authored-by: David Leal <halfpacho@gmail.com>
Panquesito7
approved these changes
Oct 10, 2021
There was a problem hiding this comment.
Awesome work! Thank you for your contribution! 😄👍🎉
You can join our Discord server and get the contributor role! 🚀
Panquesito7
added
approved
Panquesito7
requested review from
Swastyy,
ayaankhan98,
aminoxix and
mishraabhinn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the algorithm of Finding set-bits of a number which is much faster than previous one.
Checklist
Notes: