Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add the Selection Sort Recursive algorithm #1578

Merged
merged 23 commits into from
Sep 5, 2021
Merged

feat: Add the Selection Sort Recursive algorithm #1578

merged 23 commits into from
Sep 5, 2021

Conversation

Tushar-K24
Copy link
Contributor

@Tushar-K24 Tushar-K24 commented Aug 29, 2021 •
edited by gitpod-io bot
Loading

Created selection_sort_recursive.cpp

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@Panquesito7 Panquesito7 added the enhancement New feature or request label Sep 1, 2021
Panquesito7
Panquesito7 requested changes Sep 1, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah, amazing work! 😄👍
Please enable GitHub Actions in your repository of this fork in this link: https://github.com/Tushar-K24/C-Plus-Plus/actions

sorting/selection_sort_recursive.cpp Outdated Show resolved Hide resolved
sorting/selection_sort_recursive.cpp Outdated Show resolved Hide resolved
sorting/selection_sort_recursive.cpp Outdated Show resolved Hide resolved
@Panquesito7 Panquesito7 added the requested changes changes have been requested label Sep 1, 2021
@Panquesito7 Panquesito7 changed the title Create selection_sort_recursive.cpp feat: Add the Selection Sort Recursive algorithm Sep 1, 2021
Panquesito7
Panquesito7 requested changes Sep 2, 2021
View reviewed changes
sorting/selection_sort_recursive.cpp Outdated Show resolved Hide resolved
sorting/selection_sort_recursive.cpp Outdated Show resolved Hide resolved
Panquesito7
Panquesito7 requested changes Sep 3, 2021
View reviewed changes
sorting/selection_sort_recursive.cpp Outdated Show resolved Hide resolved
sorting/selection_sort_recursive.cpp Outdated Show resolved Hide resolved
sorting/selection_sort_recursive.cpp Outdated Show resolved Hide resolved
sorting/selection_sort_recursive.cpp Outdated Show resolved Hide resolved
Tushar-K24 and others added 3 commits September 4, 2021 00:06
@Tushar-K24 @Panquesito7
Update sorting/selection_sort_recursive.cpp
95f5ae4 
Co-authored-by: David Leal <halfpacho@gmail.com>
@Tushar-K24 @Panquesito7
Update sorting/selection_sort_recursive.cpp
b1a396e 
Co-authored-by: David Leal <halfpacho@gmail.com>
@Tushar-K24
Update selection_sort_recursive.cpp
ce65f32
Panquesito7
Panquesito7 requested changes Sep 3, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! 😄

sorting/selection_sort_recursive.cpp Outdated Show resolved Hide resolved
sorting/selection_sort_recursive.cpp Outdated Show resolved Hide resolved
Tushar-K24 and others added 3 commits September 4, 2021 00:22
@Tushar-K24 @Panquesito7
Update sorting/selection_sort_recursive.cpp
03ccd25 
Co-authored-by: David Leal <halfpacho@gmail.com>
@Tushar-K24 @Panquesito7
Update sorting/selection_sort_recursive.cpp
0bdd1fd 
Co-authored-by: David Leal <halfpacho@gmail.com>
@Panquesito7
Merge branch 'master' into master
5f28256
Panquesito7
Panquesito7 reviewed Sep 3, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! 😄

sorting/selection_sort_recursive.cpp Outdated Show resolved Hide resolved
sorting/selection_sort_recursive.cpp Outdated Show resolved Hide resolved
sorting/selection_sort_recursive.cpp Outdated Show resolved Hide resolved
sorting/selection_sort_recursive.cpp Outdated Show resolved Hide resolved
Tushar-K24 and others added 2 commits September 4, 2021 02:01
@Tushar-K24 @Panquesito7
Update sorting/selection_sort_recursive.cpp
4a69ca1 
Co-authored-by: David Leal <halfpacho@gmail.com>
@Tushar-K24 @Panquesito7
Update sorting/selection_sort_recursive.cpp
bfda366 
Co-authored-by: David Leal <halfpacho@gmail.com>
G3N3R4LE4RL
G3N3R4LE4RL previously approved these changes Sep 4, 2021
View reviewed changes
Panquesito7
Panquesito7 reviewed Sep 5, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! 😄

sorting/selection_sort_recursive.cpp Outdated Show resolved Hide resolved
sorting/selection_sort_recursive.cpp Outdated Show resolved Hide resolved
@Tushar-K24 @Panquesito7
Update sorting/selection_sort_recursive.cpp
227991a 
Co-authored-by: David Leal <halfpacho@gmail.com>
@Tushar-K24 @Panquesito7
Update sorting/selection_sort_recursive.cpp
20ea30d 
Co-authored-by: David Leal <halfpacho@gmail.com>
Panquesito7
Panquesito7 previously approved these changes Sep 5, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, @Tushar-K24! It's been great for your first contribution here! Thank you for your contribution! 😄👍🎉

@Panquesito7 Panquesito7 added approved Approved; waiting for merge and removed requested changes changes have been requested labels Sep 5, 2021
Tushar-K24 and others added 2 commits September 5, 2021 22:55
ayaankhan98
ayaankhan98 approved these changes Sep 5, 2021
View reviewed changes
Copy link
Member

@ayaankhan98 ayaankhan98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ayaankhan98 ayaankhan98 merged commit ea9ae3a into TheAlgorithms:master Sep 5, 2021
@Panquesito7
Copy link
Member

@ayaankhan98, next time, please wait until all the requested reviewers review this PR. 🙂

@ayaankhan98
Copy link
Member

ayaankhan98 commented Sep 5, 2021 •
edited
Loading

@ayaankhan98, next time, please wait until all the requested reviewers review this PR.

Ahh! no problem with that, I was just going with 2 reviewer policy. By the way we had 3 approved reviews on this PR.

@Panquesito7
Copy link
Member

@ayaankhan98, next time, please wait until all the requested reviewers review this PR.

Ahh! no problem with that, I was just going with 2 reviewer policy. By the way we had 3 approved reviews on this PR.

Yeah. It is because a friend of mine will start helping with reviewing PRs now. Thanks anyways. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mishraabhinn mishraabhinn mishraabhinn approved these changes

@ayaankhan98 ayaankhan98 ayaankhan98 approved these changes

@G3N3R4LE4RL G3N3R4LE4RL G3N3R4LE4RL left review comments

@Panquesito7 Panquesito7 Panquesito7 left review comments

@aminoxix aminoxix Awaiting requested review from aminoxix

Assignees
No one assigned
Labels
approved Approved; waiting for merge enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Tushar-K24 @Panquesito7 @ayaankhan98 @mishraabhinn @G3N3R4LE4RL