feat: added integral approximation algorithm #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maintains functionality but dividing by 2 is easier to read/understand
Panquesito7
requested changes
Apr 21, 2021
math/integral_approximation.cpp
Outdated
| @@ -0,0 +1,111 @@ | |||
| /** | |||
| * @file | |||
| * @brief Algorithm to compute integral approximation of function | |||
There was a problem hiding this comment.
Provide a Wikipedia link in Markdown format (if available/possible).
If there's no Wikipedia link, add another web source for algorithm explanation.
Also, add a detailed/long description of the algorithm (use @details for this).
math/integral_approximation.cpp
Outdated
Comment on lines
8
to
11
| #include <cassert> | ||
| #include <cmath> | ||
| #include <functional> | ||
| #include <iostream> |
There was a problem hiding this comment.
Add a one-line description of what the library/header is for (see the example below).
#include <cassert> /// for assert
#include <iostream> /// for IO operations
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
github-actions
bot
force-pushed
the
master
branch
2 times, most recently
from
081c080 to
23c9cfc
Compare
Co-authored-by: David Leal <halfpacho@gmail.com>
github-actions
bot
force-pushed
the
master
branch
from
79dbaff to
8ed70fc
Compare
Co-authored-by: David Leal <halfpacho@gmail.com>
github-actions
bot
force-pushed
the
master
branch
2 times, most recently
from
0d90265 to
3a53020
Compare
github-actions
bot
force-pushed
the
master
branch
2 times, most recently
from
c8816aa to
d6ac9ce
Compare
Panquesito7
reviewed
Apr 21, 2021
github-actions
bot
force-pushed
the
master
branch
from
c2eb8f8 to
7e09f2c
Compare
shiqisheng2036
approved these changes
Apr 21, 2021
shiqisheng2036
previously approved these changes
Apr 21, 2021
Panquesito7
requested changes
Apr 21, 2021
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
github-actions
bot
force-pushed
the
master
branch
2 times, most recently
from
95219b7 to
6a09e7f
Compare
Panquesito7
requested changes
Apr 21, 2021
Panquesito7
reviewed
Apr 21, 2021
Co-authored-by: David Leal <halfpacho@gmail.com>
Panquesito7
reviewed
Apr 21, 2021
math/integral_approximation.cpp
Outdated
| const std::function<double(double)>& func, | ||
| double delta = .0001) { | ||
| double result = 0; | ||
| int numDeltas = static_cast<int>((ub - lb) / delta); |
There was a problem hiding this comment.
Consider using uint64_t for non-negative values (or their appropriate size: uint32_t, uint16_t, uint8_t) or int64_t for negative values. Check other parts of the code (reference).
Panquesito7
reviewed
Apr 21, 2021
Co-authored-by: David Leal <halfpacho@gmail.com>
Panquesito7
approved these changes
Apr 22, 2021
Panquesito7
added
approved
ayaankhan98
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Algorithm that takes in a lower bound, upper bound, function, and an optional delta value and computes an integral approximation.
Checklist
Notes: