feat: Add sorting/count_inversions.cpp #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Counts the number of inversions in a list using merge sort. The number of Inversions in a list is the measure of the list's proximity to being sorted in ascending/increasing order.
|
I had previously closed this PR. @kvedala had asked to implement using templates which I did not know then. I have, since then, learned about STL library and templates from YT and formatted the code to the best of my ability. It has passed all tests. Let me know if there are any more changes you'd like to see. |
Panquesito7
changed the title
- fixed template error on line 156 - an added test case for character array - an added test case for list type double
tjgurwara99
requested changes
Nov 24, 2020
Co-authored-by: Taj <tjgurwara99@users.noreply.github.com>
Panquesito7
requested changes
Nov 24, 2020
There was a problem hiding this comment.
Please enable GitHub Actions in your repository of this fork in this link: https://github.com/rakshitraj/C-Plus-Plus/actions
Co-authored-by: Taj <tjgurwara99@users.noreply.github.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
github-actions
bot
force-pushed
the
patch-1
branch
from
b51af5e to
78ecce2
Compare
github-actions
bot
force-pushed
the
patch-1
branch
from
78ecce2 to
81560e8
Compare
and doxygen formatiing
Done. Please mark this. It is being counted as pending action. |
Panquesito7
reviewed
Nov 29, 2020
Panquesito7
reviewed
Nov 30, 2020
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
github-actions
bot
force-pushed
the
patch-1
branch
3 times, most recently
from
fcf41c4 to
0f9a744
Compare
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
github-actions
bot
force-pushed
the
patch-1
branch
from
e81cc08 to
b352ced
Compare
Update count_inversions.cpp
Co-authored-by: David Leal <halfpacho@gmail.com>
Panquesito7
reviewed
Dec 2, 2020
Co-authored-by: David Leal <halfpacho@gmail.com>
github-actions
bot
force-pushed
the
patch-1
branch
from
e8a31ae to
f941a09
Compare
Co-authored-by: David Leal <halfpacho@gmail.com>
Panquesito7
approved these changes
Dec 3, 2020
There was a problem hiding this comment.
LGTM. Thanks for your efforts and contribution, @rakshitraj! 🎉👍
Panquesito7
added
approved
|
@kvedala @ayaankhan98 please review. Thanks. 🙂 |
poyea
reviewed
Dec 9, 2020
Comment on lines
+233
to
+234
| // static void body() { | ||
| // // Input your own sequence |
There was a problem hiding this comment.
LGTM, but I'm not sure if we want this whole block commented.
There was a problem hiding this comment.
If it's all the same, I'd like the commented block to remain as a reference for any beginner who is reviewing the code. Count inversion is one of the most asked questions on Algo assignments, so most people to refer to this will likely be students.
poyea
approved these changes
Dec 9, 2020
poyea
reviewed
Dec 9, 2020
Co-authored-by: John Law <johnlaw.po@gmail.com>
|
Will merge this PR. If there are any errors, please make a new PR to propose a fix. Thank you. 🙂 |
ayaankhan98
pushed a commit
to ayaankhan98/C-Plus-Plus
that referenced
this pull request
Feb 11, 2021
* Create count_inversions.cpp Counts the number of inversions in a list using merge sort. The number of Inversions in a list is the measure of the list's proximity to being sorted in ascending/increasing order. * Update count_inversions.cpp - fixed template error on line 156 - an added test case for character array - an added test case for list type double * Update sorting/count_inversions.cpp Co-authored-by: Taj <tjgurwara99@users.noreply.github.com> * Update sorting/count_inversions.cpp Co-authored-by: Taj <tjgurwara99@users.noreply.github.com> * Update sorting/count_inversions.cpp Co-authored-by: David Leal <halfpacho@gmail.com> * updating DIRECTORY.md * clang-format and clang-tidy fixes for b51af5e * using `uint64_t` from cstdint header and doxygen formatiing * clang-format and clang-tidy fixes for 047578b * Update count_inversions.cpp * added comments on imports * clang-format and clang-tidy fixes for 2f65017 * Update sorting/count_inversions.cpp Co-authored-by: David Leal <halfpacho@gmail.com> * Update sorting/count_inversions.cpp Co-authored-by: David Leal <halfpacho@gmail.com> * Update sorting/count_inversions.cpp Co-authored-by: David Leal <halfpacho@gmail.com> * Update sorting/count_inversions.cpp Co-authored-by: David Leal <halfpacho@gmail.com> * Update count_inversions.cpp * clang-format and clang-tidy fixes for 5d5cc53 * Update sorting/count_inversions.cpp Co-authored-by: David Leal <halfpacho@gmail.com> * Update sorting/count_inversions.cpp Co-authored-by: David Leal <halfpacho@gmail.com> * Update sorting/count_inversions.cpp Co-authored-by: David Leal <halfpacho@gmail.com> * Update sorting/count_inversions.cpp Co-authored-by: David Leal <halfpacho@gmail.com> * Update sorting/count_inversions.cpp Co-authored-by: David Leal <halfpacho@gmail.com> * Update sorting/count_inversions.cpp Co-authored-by: David Leal <halfpacho@gmail.com> * Update sorting/count_inversions.cpp Co-authored-by: David Leal <halfpacho@gmail.com> * Update sorting/count_inversions.cpp Co-authored-by: David Leal <halfpacho@gmail.com> * Update sorting/count_inversions.cpp Co-authored-by: David Leal <halfpacho@gmail.com> * Update sorting/count_inversions.cpp Co-authored-by: David Leal <halfpacho@gmail.com> * Update sorting/count_inversions.cpp Co-authored-by: David Leal <halfpacho@gmail.com> * Update sorting/count_inversions.cpp Co-authored-by: David Leal <halfpacho@gmail.com> * Update count_inversions.cpp * Update sorting/count_inversions.cpp Co-authored-by: David Leal <halfpacho@gmail.com> * Update sorting/count_inversions.cpp Co-authored-by: David Leal <halfpacho@gmail.com> * Update sorting/count_inversions.cpp Co-authored-by: David Leal <halfpacho@gmail.com> * Update count_inversions.cpp * clang-format and clang-tidy fixes for 121ce33 * Update sorting/count_inversions.cpp Co-authored-by: John Law <johnlaw.po@gmail.com> Co-authored-by: Taj <tjgurwara99@users.noreply.github.com> Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com> Co-authored-by: John Law <johnlaw.po@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Counts the number of inversions in a list using merge sort. The number of Inversions in a list is the measure of the list's proximity to being sorted in ascending/increasing order.
Description of Change
Checklist
Notes: