Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new implementation of binary search tree #1208

Merged
merged 11 commits into from
Feb 5, 2021
Merged

feat: add new implementation of binary search tree #1208

merged 11 commits into from
Feb 5, 2021

Conversation

Walt280
Copy link
Contributor

@Walt280 Walt280 commented Oct 7, 2020 •
edited by gitpod-io bot
Loading

Description of Change

Add new implementation of binary search tree code using oop, generics, and smart pointers.
Add basic documentation to each of the BST functions.
Add tests for each BST function.

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

@kvedala
Copy link
Collaborator

kvedala commented Oct 7, 2020

If you would like to add a new implementation, review the guidelines. Review the guidelines and the checklist.

@kvedala kvedala added automated tests are failing Do not merge until tests pass awaiting modification Do not merge until modifications are made enhancement New feature or request good first issue Good for newcomers labels Oct 7, 2020
@Walt280 Walt280 marked this pull request as draft October 7, 2020 01:23
@Walt280 Walt280 changed the title fix: revamp binary_search_tree.cpp feat: add new implementation of binary search tree Oct 7, 2020
@Walt280 Walt280 marked this pull request as ready for review October 7, 2020 01:58
@Walt280
Copy link
Contributor Author

Walt280 commented Oct 7, 2020

Okay, I've moved the implementation into a new file.

@Walt280
Copy link
Contributor Author

Walt280 commented Oct 8, 2020

This PR is ready for review.

kvedala
kvedala requested changes Oct 16, 2020
View reviewed changes
Copy link
Collaborator

@kvedala kvedala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

data_structures/binary_search_tree2.cpp Show resolved Hide resolved
data_structures/binary_search_tree2.cpp Outdated Show resolved Hide resolved
data_structures/binary_search_tree2.cpp Outdated Show resolved Hide resolved
data_structures/binary_search_tree2.cpp Outdated Show resolved Hide resolved
data_structures/binary_search_tree2.cpp Show resolved Hide resolved
data_structures/binary_search_tree2.cpp Outdated Show resolved Hide resolved
data_structures/binary_search_tree2.cpp Show resolved Hide resolved
data_structures/binary_search_tree2.cpp Show resolved Hide resolved
data_structures/binary_search_tree2.cpp Outdated Show resolved Hide resolved
data_structures/binary_search_tree2.cpp Outdated Show resolved Hide resolved
@Walt280 Walt280 requested a review from kvedala October 21, 2020 00:24
kvedala
kvedala requested changes Oct 21, 2020
View reviewed changes
data_structures/binary_search_tree2.cpp Outdated Show resolved Hide resolved
data_structures/binary_search_tree2.cpp Outdated Show resolved Hide resolved
data_structures/binary_search_tree2.cpp Outdated Show resolved Hide resolved
Walt280 and others added 3 commits October 21, 2020 13:46
@Walt280 Walt280 requested a review from kvedala October 21, 2020 18:04
@kvedala kvedala merged commit 6b4d6c2 into TheAlgorithms:master Feb 5, 2021
ayaankhan98 pushed a commit to ayaankhan98/C-Plus-Plus that referenced this pull request Feb 11, 2021
@Walt280 @kvedala @ayaankhan98
feat: add new implementation of binary search tree (TheAlgorithms#1208)
a4f5839 
* fix: revamp binary_search_tree.cpp to use generics, oop, and modern c++ features

* fix: remove make_unique from code

* fix: fix some clang-tidy errors in binary_search_tree.cpp

* Move new implementation into new file, restore old file.

* Reset binary_search_tree.cpp to original implementation.

* Add link to new implementation.

* fix: add suggested fixes (see PR)

* Implement comment suggestions.

* Update data_structures/binary_search_tree2.cpp

Co-authored-by: Krishna Vedala <7001608+kvedala@users.noreply.github.com>

* Fix additional comments.

Co-authored-by: Krishna Vedala <7001608+kvedala@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvedala kvedala kvedala approved these changes

Assignees
No one assigned
Labels
automated tests are failing Do not merge until tests pass awaiting modification Do not merge until modifications are made enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Walt280 @kvedala