mock-array: fix large negative slack for Element #2749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we want slight negative slack for testing purposes Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
|
I would assume this requires a metrics update |
No, this affects reg2reg paths inside the Element only. There are no metrics for Element, only for mock-array. |
maliberty
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we want slight negative slack for testing purposes.
Ended up with the simplest solution I could think of, just reduce the output width of the multiplier and let synthesis optimize away the rest.
The simpler Element also speeds up Verilator significantly.