Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sky130's and ihp: Honor cell footprint by default and update metrics #2692

Merged
merged 2 commits into from
Feb 6, 2025
Merged

sky130's and ihp: Honor cell footprint by default and update metrics #2692

merged 2 commits into from
Feb 6, 2025
+1,114 −1,091

Conversation

AcKoucher
Copy link
Contributor

@AcKoucher AcKoucher commented Jan 20, 2025 •
edited
Loading

Resolve #2553

Metrics Updates

sky130hd

ibex

Metric Old New Type
globalroute__antenna_diodes_count 112 78 Tighten
detailedroute__antenna_diodes_count 42 62 Failing

jpeg

Metric Old New Type
globalroute__antenna_diodes_count 529 406 Tighten
detailedroute__antenna_diodes_count 61 122 Failing

sky130hs

aes

Metric Old New Type
globalroute__antenna_diodes_count 8 86 Failing
detailedroute__route__wirelength 613182 719943 Failing
detailedroute__antenna_diodes_count 19 27 Failing
finish__timing__setup__ws -0.39 -0.2 Tighten

ibex

Metric Old New Type
globalroute__antenna_diodes_count 7 24 Failing
detailedroute__antenna_diodes_count 19 32 Failing

riscv32i

Metric Old New Type
globalroute__antenna_diodes_count 0 1 Failing
detailedroute__route__wirelength 352023 347723 Tighten

ihp

spi

Metric Old New Type
detailedroute__route__wirelength 4194 4994 Failing
finish__timing__setup__ws -0.2 -0.16 Tighten
finish__design__instance__area 10462 10447 Tighten
finish__timing__wns_percent_delay -25.27 -21.65 Tighten

@AcKoucher
Copy link
Contributor Author

AcKoucher commented Jan 20, 2025 •
edited
Loading

This changes cause uW to fail with high congestion. There's a GRT config change that will be done in this same design in order to merge #5809. My expectations are that it will also allow the changes here.

Apart from that , secure-CI showed no problematic QoR degradation - there are some metrics to be updated though.

@AcKoucher AcKoucher force-pushed the secure-platforms-match-cell-footprint branch from 1141241 to 6308ab6 Compare January 20, 2025 16:59
@AcKoucher
Copy link
Contributor Author

Update: I tested again with the IO constraints inside MPL, the allowance of boundary push in MPL and with the routing layer adjustment reduction. I still got a high congestion problem.

Some investigation showed that this looks like a bug in GRT: the size of the ITerms seems to be causing GRT to use the wrong GCell. @eder-matheus is taking a look.

@eder-matheus eder-matheus mentioned this pull request Jan 30, 2025
Merged
@AcKoucher AcKoucher force-pushed the secure-platforms-match-cell-footprint branch from 6308ab6 to e220808 Compare February 2, 2025 18:14
@AcKoucher AcKoucher changed the title sky130hd, sky130hs and ihp: Honor cell footprint by default sky130's and ihp: Honor cell footprint by default and update metrics Feb 2, 2025
@AcKoucher AcKoucher marked this pull request as ready for review February 2, 2025 18:22
@AcKoucher AcKoucher requested a review from maliberty February 2, 2025 18:22
@AcKoucher AcKoucher force-pushed the secure-platforms-match-cell-footprint branch 3 times, most recently from e1ba90a to 2f110fb Compare February 4, 2025 21:19
@AcKoucher
Copy link
Contributor Author

Ready to merge.

@AcKoucher
sky130hd, sky130hs and ihp: Honor cell footprint in all sizing operat…
dd58aab 
…ions

Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
@AcKoucher AcKoucher force-pushed the secure-platforms-match-cell-footprint branch from 2f110fb to dd58aab Compare February 5, 2025 23:19
@AcKoucher
Copy link
Contributor Author

Another metrics conflict emerged. I'm re-running the test-CI.

@AcKoucher
Update metrics for match cell footprint by default on the following d…
966c117 
…esings:

sky130hd
   -ibex
   -jpeg
sky130hs
   -aes
   -ibex
   -riscv32i
ihp-sg13g2
   -spi

Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
@AcKoucher
Copy link
Contributor Author

@eder-matheus This should be good to merge.

@eder-matheus eder-matheus merged commit 8477d46 into The-OpenROAD-Project:master Feb 6, 2025
7 checks passed
@AcKoucher AcKoucher deleted the secure-platforms-match-cell-footprint branch February 6, 2025 15:20
@eder-matheus eder-matheus mentioned this pull request Feb 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eder-matheus eder-matheus

@maliberty maliberty

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Honor Cell Footprint in sky130hd, sky130hs and ihp
2 participants
@AcKoucher @eder-matheus