Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Artifact Reorganization #723

Merged
merged 22 commits into from
Nov 23, 2021
Merged

Artifact Reorganization #723

merged 22 commits into from
Nov 23, 2021

Conversation

donn
Copy link
Collaborator

@donn donn commented Nov 19, 2021 •
edited
Loading

The best thing to happen to OpenLane since OpenLane.

Variables related to output files: i.e. logs, results and reports, are becoming more uniform.

  • Variables now point to folders
  • Variables now called {stage}_{type}s
  • All variables renamed to be tool-generic
    • magic, klayout, cvc and lvs all unified, renamed "finishing"
  • Better flow runtime calculation
    • All step runtimes are now stored in a yaml file, which can easily be read by a human or parsed by a computer.
  • Better step indexing
    • You have to increment the step index explicitly using increment_index.
    • Functions that take log arguments now require you to not use an indexed file, it's their responsibility to index them.
  • Changed names for many logs to make more sense
  • A plethora of files being moved and/or renamed
    • Yosys scripts were moved into their own folder
    • All references to OpenLANE that are not a published paper have been replaced with OpenLane
    • Copyright dates updated on some files

A note to all reviewers, don't merge, just approve. Let me handle it.

donn added 20 commits November 18, 2021 18:21
@donn
Rework runtime calculation
8450099
@donn
prep structure slight code cleanup
8fc2661
@donn
Genericize Tool Names
843a2b0
@donn
Move yosys scripts to their own folder
d9e6bf7
@donn
file_tag -> plural
4e15c5c
@donn
Consolidated into less folders
6df1213
@donn
More consistent file structure
66eaae8 
Some files are still in the wrong place
Report generation is still broken
@donn
Env var tweaks- indexing still inconsistent
eebd239
@donn
Fixed reports, some names still ?
c9b0a61
@donn
Overhauled total_runtime and routed_runtime storage and parsing
1c00a5c
@donn
Merge remote-tracking branch 'upstream/master' into run_structure
5fb8d8e
@donn
magic, klayout, lvs, erc -> finishing, qor
2bbb929
@donn
Rework index increments
931a072
@donn
fix lvs log path
e127d1e
@donn
Fix magic result detection
6a4c6b1
@donn
Yet another test fix
6943a4c
@donn
Custom output logs for spef extractions, more increments, antenna mov…
af53787 
…ed to qor
@donn
Remove remaining instances of OpenLANE for consistency
8dadba9
@donn
Merged finishing and qor
ad5cf5f 
qor is basically just the logs and reports from finishing anyway
@donn
Moved first timing resizing to cts, more indexing fixes
c2f1758 
Calling convention now is when you pass a log, you don't pass an indexed file. The step is responsible for indexing the file you name.
@donn donn marked this pull request as ready for review November 23, 2021 12:37
Manarabdelaty
Manarabdelaty previously approved these changes Nov 23, 2021
View reviewed changes
@donn donn changed the title Run Folder Rework Artifact Reorganization Nov 23, 2021
@kareefardi
- formatting
7148230 
- rename rsz and rsizer to resizer
- rename gplace to global
- rename floorplan to initial_fp
@donn donn merged commit 3bc6fcd into The-OpenROAD-Project:master Nov 23, 2021
@donn donn deleted the run_structure branch November 24, 2021 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kareefardi kareefardi kareefardi approved these changes

@Manarabdelaty Manarabdelaty Manarabdelaty left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@donn @kareefardi @Manarabdelaty