Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Build System to Match OpenLane 2 #2115

Merged
merged 26 commits into from
May 8, 2024
Merged

Migrate Build System to Match OpenLane 2 #2115

merged 26 commits into from
May 8, 2024

Conversation

donn
Copy link
Collaborator

@donn donn commented Apr 7, 2024 •
edited
Loading

This makes OpenLane use a Nix 3-based build system in place of the ad-hoc tool_metadata.yaml + Docker-based build-system.

A Docker image is still the ultimate product, so there is no impact on the end-user (other than yum no longer being a thing.)

This PR also effectively synchronizes all tool versions with those of OpenLane 2.

+ Repository is now a Nix flake
~ Change all invocations of `openroad -python` to use `run_odbpy_script` for consistency
~ Change build system from ad-hoc to Nix, still producing a Docker image as a final result
~ Update KLayout scripts to use `klayout-pymod` or properly parse commandline arguments
~ `open_pdks` -> `bdc9412` to match OpenLane 2
- Remove local installer; `nix run .` will run OpenLane natively

@donn donn requested a review from kareefardi April 7, 2024 23:34
@donn donn marked this pull request as ready for review April 8, 2024 13:55
kareefardi
kareefardi reviewed Apr 8, 2024
View reviewed changes
docker/build.sh Outdated Show resolved Hide resolved
@donn donn requested a review from kareefardi April 8, 2024 19:37
kareefardi
kareefardi previously approved these changes Apr 8, 2024
View reviewed changes
@donn donn marked this pull request as draft April 17, 2024 13:28
@donn donn marked this pull request as ready for review April 28, 2024 09:09
@donn donn requested a review from kareefardi May 2, 2024 16:42
@donn donn merged commit 14b94a6 into master May 8, 2024
93 checks passed
@donn donn deleted the nixify branch May 8, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kareefardi kareefardi kareefardi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@donn @kareefardi