Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OpenROAD + Handle Breaking Changes #1949

Merged
merged 10 commits into from
Sep 5, 2023
Merged

Update OpenROAD + Handle Breaking Changes #1949

merged 10 commits into from
Sep 5, 2023

Conversation

kareefardi
Copy link
Collaborator

@kareefardi kareefardi commented Aug 21, 2023 •
edited by donn
Loading 

+ update utils.py `fetch_submodules_from_tarballs` to handle relative submodule url
~ openroad_app -> `0a6d0fd`
~ add workaround for liberty files lacking default operating conditions such as in gf180mcu, which breaks with the latest versions of OR

Fixes #1930

@kareefardi
bump openroad version
5efb6da 
update utils.py fetch_submodules_from_tarballs to handle relative
submodule url
@kareefardi kareefardi marked this pull request as ready for review August 21, 2023 17:28
@donn
Copy link
Collaborator

donn commented Aug 21, 2023

Why are you updating OR?

@kareefardi
Copy link
Collaborator Author

Why are you updating OR?

For #1930

@donn donn changed the title Handle relative submodule url in utils.py Update OpenROAD + Handle Breaking Changes Aug 30, 2023
@maliberty
Copy link
Member

@donn @kareefardi can this be merged?

@donn
Copy link
Collaborator

donn commented Aug 31, 2023

@maliberty As soon as aarch64 builds

Screenshot at 2023-08-31 19:15:10

@donn
Copy link
Collaborator

donn commented Sep 4, 2023

todo: donn figure this shit out

@donn donn self-assigned this Sep 4, 2023
@donn donn added the OL2 Parity This PR introduces significant changes which will need to be introduced into OpenLane 2 label Sep 4, 2023
@donn donn merged commit d03ecd9 into The-OpenROAD-Project:master Sep 5, 2023
@kareefardi kareefardi mentioned this pull request Sep 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donn donn donn approved these changes

Assignees

@donn donn

Labels
OL2 Parity This PR introduces significant changes which will need to be introduced into OpenLane 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resizer got stuck
3 participants
@kareefardi @donn @maliberty