Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDC Behavior Overhaul #1944

Merged
merged 13 commits into from
Sep 5, 2023
Merged

SDC Behavior Overhaul #1944

merged 13 commits into from
Sep 5, 2023

Conversation

kareefardi
Copy link
Collaborator

@kareefardi kareefardi commented Aug 13, 2023 •
edited
Loading 

+ Add PNR_SDC_FILE
+ Warn when (PNR|SIGNOFF)_SDC_FILE are not overwritten by the user.
+ Add SDC_IN and DEFAULT_SDC_FILE to ignore list in CI
+ Add per corner max slew/fanout/cap count to sta report
+ Add per corner worst hold and setup value to sta report 
~ Rename RCX_SDC_FILE to SIGNOFF_SDC_FILE.
~ Always use PNR_SDC_FILE instead of CURRENT_SDC except during signoff stage, where SIGNOFF_SDC_FILE is used instead
~ Enable DIODE_ON_PORTS and RUN_HEURISTIC_DIODE_INSERTION for APU which fails after SDC updates.
~ Adjust timing checkers according to the new reported values

@kareefardi kareefardi changed the title Sdc enhancements again Enhancements to variables related to SDC Aug 14, 2023
@kareefardi kareefardi marked this pull request as ready for review August 14, 2023 14:40
donn
donn reviewed Aug 15, 2023
View reviewed changes
configuration/general.tcl Show resolved Hide resolved
docs/source/reference/configuration.md Outdated Show resolved Hide resolved
scripts/openroad/common/io.tcl Outdated Show resolved Hide resolved
scripts/tcl_commands/synthesis.tcl Outdated Show resolved Hide resolved
@donn donn changed the title Enhancements to variables related to SDC SDC Behavior Overhaul Aug 31, 2023
donn
donn approved these changes Aug 31, 2023
View reviewed changes
Copy link
Collaborator

@donn donn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine now

@donn donn self-requested a review August 31, 2023 08:45
donn
donn requested changes Aug 31, 2023
View reviewed changes
scripts/tcl_commands/sta.tcl Show resolved Hide resolved
@kareefardi kareefardi requested a review from donn September 4, 2023 10:08
@donn donn added the OL2 Parity This PR introduces significant changes which will need to be introduced into OpenLane 2 label Sep 4, 2023
@donn donn merged commit 5fb033c into The-OpenROAD-Project:master Sep 5, 2023
@kareefardi kareefardi mentioned this pull request Sep 9, 2023
Closed
@kareefardi kareefardi mentioned this pull request Dec 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donn donn donn approved these changes

Assignees
No one assigned
Labels
OL2 Parity This PR introduces significant changes which will need to be introduced into OpenLane 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kareefardi @donn