IR Drop Reports in the Signoff Stage #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delete extra space in Magic section, formatted. Signed-off-by: Donn <me@donn.website>
all: excludes global routing because i'm in the process of rewriting that whole thing and lvs because that thing is a nightmare
|
You have a lot of changes in here that are unrelated to the title of this PR. I don't intend to review them (lvs, klayout, magic, docs, etc). |
maliberty
previously requested changes
Aug 8, 2022
kareefardi
reviewed
Aug 8, 2022
kareefardi
reviewed
Aug 8, 2022
kareefardi
reviewed
Aug 8, 2022
|
@maliberty Just as long as you're okay with where irdrop is in the flow. Your approval is not needed for the rest. I'll be adding the liberty file shortly. |
kareefardi
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
+ Create new IR drop report generation step in the signoff stage
+ ALL* STEPS NOW PRINT THEIR LOGS' PATH
~
increment_index/TIMER/set log/puts_infocommands organized across the board~ Fix issue where
FP_PDN_AUTO_ADJUSTwould not snap its values to the mfg grid~ Reorder
configuration/general.tcl~ Update Contribution Guidelines
~ Various Docs Fixes
- Remove
FP_PDN_IRDROP* All /ɔːl/ noun: used to refer to the whole quantity or extent of a particular group or thing so long as said thing does not include global routing or lvs as they are written quite poorly.
Resolves #1238
Resolves #1241
Resolves #1247