Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GLB_RT -> GRT + Remove older deprecated variables #1217

Merged
merged 1 commit into from
Jul 20, 2022
Merged

GLB_RT -> GRT + Remove older deprecated variables #1217

merged 1 commit into from
Jul 20, 2022

Conversation

donn
Copy link
Collaborator

@donn donn commented Jul 19, 2022 •
edited
Loading

~ For consistency's sake, all variables previously starting with GLB_RT have been changed to ones starting with GRT (except for PDK variable GLB_RT_LAYER_ADJUSTMENTS)
~ GLB_RT-prefixed variables deprecated, automatically translated to equivalents by OpenLane (for now)

  • Removed of GLB_RT_LX_ADJUSTMENT deprecated variables translation behavior
  • Removed GLB_RT_[CLOCK_]{MIN/MAX}LAYER deprecated variables translation behavior
  • Removed ROUTING_OPT_ITERS deprecated variable translation behavior

As requested by @shalan

@donn
GLB_RT -> GRT
fafbb65 
~ For consistency's sake, all variables previously starting with GLB_RT have been changed to ones starting with GRT (except for PDK variable `GLB_RT_LAYER_ADJUSTMENTS`)
~ GLB_RT-prefixed variables deprecated, automatically translated to equivalents by OpenLane (for now)
- Removed GLB_RT_[CLOCK_]_{MIN/MAX}LAYER deprecated variable translation behavior
- Removed ROUTING_OPT_ITERS deprecated variable translation behavior
@donn donn requested a review from kareefardi July 19, 2022 14:01
@donn donn mentioned this pull request Jul 19, 2022
Closed
@kareefardi
Copy link
Collaborator

what happens if a configuration file still has ROUTING_OPT_ITERS

@donn
Copy link
Collaborator Author

donn commented Jul 20, 2022

what happens if a configuration file still has ROUTING_OPT_ITERS

They had about two years of warnings to change it.

@donn donn merged commit 23ab827 into The-OpenROAD-Project:master Jul 20, 2022
@donn donn deleted the glb_rt_to_grt branch July 26, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kareefardi kareefardi kareefardi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@donn @kareefardi